On 2020-05-01 21:34, Chris Plummer wrote:
On 4/30/20 2:07 AM, Stefan Karlsson wrote:
...
There was one odd thing in jdi that requires extra scrutiny:
https://cr.openjdk.java.net/~stefank/8244078/webrev.01/test/jdk/com/sun/jdi/lib/jdb/Debuggee.java.udiff.html
Yes, that did look a odd at firs
On 4/30/20 2:07 AM, Stefan Karlsson wrote:
Hi all,
Please review this patch to make it less likely that we accidentally
add or fail to add test.java.opts and test.vm.opts to our spawned test
JVMs.
https://cr.openjdk.java.net/~stefank/8244078/webrev.01/
https://bugs.openjdk.java.net/browse/JD
On 30/04/2020 11:08, Stefan Karlsson wrote:
Are you specifically referring to executeTestJvm vs executeTestJava?
Yes, executeTestJvm was deprecated in the
test/lib/testlibrary/jdk/testlibrary/ProcessTools.java but it seems to
have come back, maybe when we move to a single repo. I only bring it
On 2020-04-30 12:22, Stefan Karlsson wrote:
Hi David,
On 2020-04-30 11:59, David Holmes wrote:
...
---
test/hotspot/jtreg/gc/arguments/GCArguments.java
Isn't the String[] <-> List conversion already handled in
ProcessTools?
This looks like an area where GC added its own helper utilities
Hi David,
On 2020-04-30 11:59, David Holmes wrote:
Hi Stefan,
On 30/04/2020 7:07 pm, Stefan Karlsson wrote:
Hi all,
Please review this patch to make it less likely that we accidentally
add or fail to add test.java.opts and test.vm.opts to our spawned
test JVMs.
https://cr.openjdk.java.net
On 2020-04-30 11:24, Alan Bateman wrote:
On 30/04/2020 10:07, Stefan Karlsson wrote:
Hi all,
Please review this patch to make it less likely that we accidentally
add or fail to add test.java.opts and test.vm.opts to our spawned
test JVMs.
https://cr.openjdk.java.net/~stefank/8244078/webrev.
Hi Stefan,
On 30/04/2020 7:07 pm, Stefan Karlsson wrote:
Hi all,
Please review this patch to make it less likely that we accidentally add
or fail to add test.java.opts and test.vm.opts to our spawned test JVMs.
https://cr.openjdk.java.net/~stefank/8244078/webrev.01/
https://bugs.openjdk.java
On 30/04/2020 10:07, Stefan Karlsson wrote:
Hi all,
Please review this patch to make it less likely that we accidentally
add or fail to add test.java.opts and test.vm.opts to our spawned test
JVMs.
https://cr.openjdk.java.net/~stefank/8244078/webrev.01/
https://bugs.openjdk.java.net/browse/J
Hi all,
Please review this patch to make it less likely that we accidentally add
or fail to add test.java.opts and test.vm.opts to our spawned test JVMs.
https://cr.openjdk.java.net/~stefank/8244078/webrev.01/
https://bugs.openjdk.java.net/browse/JDK-8244078
ProcessTools.createJavaProcessBuil
