Re: RFR: 8244224: Implementation of JEP 381: Remove the Solaris and SPARC Ports (serviceability)

Hi Mikael, The summary looks correct. The fix looks good to me. Thanks, Serguei On 5/6/20 22:44, Mikael Vidstedt wrote: To summarize the status: I have not made any changes to the serviceability patch itself, but I did remove generateJvmOffsets.cpp as part of the build system patch. I belie

Re: RFR: 8244224: Implementation of JEP 381: Remove the Solaris and SPARC Ports (serviceability)

> On May 6, 2020, at 3:19 PM, serguei.spit...@oracle.com wrote: > > > > On 5/6/20 11:12, serguei.spit...@oracle.com > wrote: >> On 5/6/20 10:58, coleen.phillim...@oracle.com >> wrote: >>> >>> >>> On 5/6/20 1:04 PM, s

Re: RFR: 8244224: Implementation of JEP 381: Remove the Solaris and SPARC Ports (serviceability)

To summarize the status: I have not made any changes to the serviceability patch itself, but I did remove generateJvmOffsets.cpp as part of the build system patch. I believe the following items remain: * File follow-up(s) to update comments * File follow-up to rename the #ifdef guards in sr

Re: RFR: 8244224: Implementation of JEP 381: Remove the Solaris and SPARC Ports (serviceability)

On 5/6/20 11:12, serguei.spit...@oracle.com wrote: On 5/6/20 10:58, coleen.phillim...@oracle.com wrote: On 5/6/20 1:04 PM, serguei.spit...@oracle.com wrote: On 5/6/20 03:40, coleen.phillim...@oracle

Re: RFR: 8244224: Implementation of JEP 381: Remove the Solaris and SPARC Ports (serviceability)

On 5/6/20 10:58, coleen.phillim...@oracle.com wrote: On 5/6/20 1:04 PM, serguei.spit...@oracle.com wrote: On 5/6/20 03:40, coleen.phillim...@oracle.com wrote: On 5/6/20 2:09 AM, serguei.

Re: RFR: 8244224: Implementation of JEP 381: Remove the Solaris and SPARC Ports (serviceability)

On 5/6/20 1:04 PM, serguei.spit...@oracle.com wrote: On 5/6/20 03:40, coleen.phillim...@oracle.com wrote: On 5/6/20 2:09 AM, serguei.spit...@oracle.com wrote: On 5/5/20 17:04, Mikael Vidstedt wrote: On May 5, 2020, at 4:48 PM,serguei.spit...@oracle.com wrote: Hi Mikael, The fixes in web

Re: RFR: 8244224: Implementation of JEP 381: Remove the Solaris and SPARC Ports (serviceability)

On 5/6/20 07:27, Magnus Ihse Bursie wrote: On 2020-05-06 12:40, coleen.phillim...@oracle.com wrote: On 5/6/20 2:09 AM, serguei.spit...@oracle.com wrote: On 5/5/20 17:04, Mikael Vidstedt

Re: RFR: 8244224: Implementation of JEP 381: Remove the Solaris and SPARC Ports (serviceability)

On 5/6/20 03:40, coleen.phillim...@oracle.com wrote: On 5/6/20 2:09 AM, serguei.spit...@oracle.com wrote: On 5/5/20 17:04, Mikael Vidstedt wrote: On May 5, 2020, at 4:48 PM, serguei.spi

Re: RFR: 8244224: Implementation of JEP 381: Remove the Solaris and SPARC Ports (serviceability)

On 2020-05-06 12:40, coleen.phillim...@oracle.com wrote: On 5/6/20 2:09 AM, serguei.spit...@oracle.com wrote: On 5/5/20 17:04, Mikael Vidstedt wrote: On May 5, 2020, at 4:48 PM,serguei.spit...@oracle.com wrote: Hi Mikael, The fixes in webrev look good to me. I've just noticed a couple o

Re: RFR: 8244224: Implementation of JEP 381: Remove the Solaris and SPARC Ports (serviceability)

On 5/6/20 2:09 AM, serguei.spit...@oracle.com wrote: On 5/5/20 17:04, Mikael Vidstedt wrote: On May 5, 2020, at 4:48 PM,serguei.spit...@oracle.com wrote: Hi Mikael, The fixes in webrev look good to me. I've just noticed a couple of more serviceability related things can be missed. (Not sur

Re: RFR: 8244224: Implementation of JEP 381: Remove the Solaris and SPARC Ports (serviceability)

On 5/5/20 17:04, Mikael Vidstedt wrote: On May 5, 2020, at 4:48 PM, serguei.spit...@oracle.com wrote: Hi Mikael, The fixes in webrev look good to me. I've just noticed a couple of more serviceability related things can be missed. (Not sure if they are

Re: RFR: 8244224: Implementation of JEP 381: Remove the Solaris and SPARC Ports (serviceability)

On 5/5/20 17:04, Mikael Vidstedt wrote: On May 5, 2020, at 4:48 PM, serguei.spit...@oracle.com wrote: Hi Mikael, The fixes in webrev look good to me. I've just noticed a couple of more serviceability related things can be missed. (Not sure if they are included into different chunk of fixes.)

Re: RFR: 8244224: Implementation of JEP 381: Remove the Solaris and SPARC Ports (serviceability)

> On May 5, 2020, at 4:48 PM, serguei.spit...@oracle.com wrote: > > Hi Mikael, > > The fixes in webrev look good to me. > > I've just noticed a couple of more serviceability related things can be > missed. > (Not sure if they are included into different chunk of fixes.) > > One is libjvm_db

Re: RFR: 8244224: Implementation of JEP 381: Remove the Solaris and SPARC Ports (serviceability)

Hi Mikael, The fixes in webrev look good to me. I've just noticed a couple of more serviceability related things can be missed. (Not sure if they are included into different chunk of fixes.) One is libjvm_db.so which is for Solaris Pstack support:   make/hotspot/lib/CompileDtraceLibraries.gmk

Re: RFR: 8244224: Implementation of JEP 381: Remove the Solaris and SPARC Ports (serviceability)

All good points! I deliberately chose *not* to update comments where it wasn’t immediately 100% obvious exactly how to update them. For example, in many cases I found that the comments are already incomplete or stale, and for each such case we’ll want to consider how exactly to update the comm

Re: RFR: 8244224: Implementation of JEP 381: Remove the Solaris and SPARC Ports (serviceability)

HI Mikael, Some quick comments. Some extra references to Solaris/solaris, SunOS or SPARC are listed below: src/java.instrument/unix/native/libinstrument/FileSystemSupport_md.c (2 refs to Solaris/solaris) src/java.management/share/classes/javax/management/loading/MLet.java (refs to Solaris, SP

RFR: 8244224: Implementation of JEP 381: Remove the Solaris and SPARC Ports (serviceability)

Please review this change which implements part of JEP 381: JBS: https://bugs.openjdk.java.net/browse/JDK-8244224 webrev: http://cr.openjdk.java.net/~mikael/webrevs/8244224/webrev.00/serviceability/open/webrev/ JEP: https://bugs.openjdk.java.net/browse/JDK-8241787 Note: When reviewing this, p