Re: RFR: 8245446: vmTestbase/nsk/jvmti/RedefineClasses/StressRedefine/TestDescription.java crash intermittently

2020-12-09 Thread Harold Seigel
On Wed, 9 Dec 2020 16:33:22 GMT, Coleen Phillimore wrote: > This change handles redefinition during method resolution, by returning the > new method. It's not needed to reresolve the invocation. See the bug for > more information. > > Tested with tier1-3 and tier8 on linux-x64-debug and macos

Re: RFR: 8245446: vmTestbase/nsk/jvmti/RedefineClasses/StressRedefine/TestDescription.java crash intermittently

2020-12-09 Thread Coleen Phillimore
On Wed, 9 Dec 2020 17:21:16 GMT, Serguei Spitsyn wrote: >> This change handles redefinition during method resolution, by returning the >> new method. It's not needed to reresolve the invocation. See the bug for >> more information. >> >> Tested with tier1-3 and tier8 on linux-x64-debug and ma

Re: RFR: 8245446: vmTestbase/nsk/jvmti/RedefineClasses/StressRedefine/TestDescription.java crash intermittently

2020-12-09 Thread Serguei Spitsyn
On Wed, 9 Dec 2020 16:33:22 GMT, Coleen Phillimore wrote: > This change handles redefinition during method resolution, but returning the > new method. It's not needed to reresolve the invocation. See the bug for > more information. > > Tested with tier1-3 and tier8 on linux-x64-debug and maco

Re: RFR: 8245446: vmTestbase/nsk/jvmti/RedefineClasses/StressRedefine/TestDescription.java crash intermittently

2020-12-09 Thread Serguei Spitsyn
On Wed, 9 Dec 2020 13:22:58 GMT, Coleen Phillimore wrote: >> We had a private slack chat with Coleen. >> Coleen suggested a nice fix in the InterpreterRuntime::resolve_invoke which >> I like. >> My mach5 job with Coleen's patch doing 100 StressRedefine tests runs is >> passed. >> So, most likel

RFR: 8245446: vmTestbase/nsk/jvmti/RedefineClasses/StressRedefine/TestDescription.java crash intermittently

2020-12-09 Thread Coleen Phillimore
This change handles redefinition during method resolution, but returning the new method. It's not needed to reresolve the invocation. See the bug for more information. Tested with tier1-3 and tier8 on linux-x64-debug and macos-x64-debug, and running the failing tests 100x without failure. Tha

Re: RFR: 8245446: vmTestbase/nsk/jvmti/RedefineClasses/StressRedefine/TestDescription.java crash intermittently

2020-12-09 Thread Coleen Phillimore
On Wed, 9 Dec 2020 01:31:16 GMT, Serguei Spitsyn wrote: >> I don't get serviceability-dev mail anymore because it was being duplicated >> with hotspot-runtime-dev most of the time. I don't think this fixes the >> problem, it only makes the test less stressful. Both of these tests find a >> l

Re: RFR: 8245446: vmTestbase/nsk/jvmti/RedefineClasses/StressRedefine/TestDescription.java crash intermittently

2020-12-08 Thread Serguei Spitsyn
On Wed, 9 Dec 2020 00:26:38 GMT, Coleen Phillimore wrote: >> looks good. > > I don't get serviceability-dev mail anymore because it was being duplicated > with hotspot-runtime-dev most of the time. I don't think this fixes the > problem, it only makes the test less stressful. Both of these te

Re: RFR: 8245446: vmTestbase/nsk/jvmti/RedefineClasses/StressRedefine/TestDescription.java crash intermittently

2020-12-08 Thread Coleen Phillimore
On Tue, 8 Dec 2020 21:17:16 GMT, Leonid Mesnik wrote: >> The StressRedefine.java (base for redefine stress tests) defines 3 important >> constants: >> private static int staticMethodCallersNumber = 10; >> private static int nonstaticMethodCallersNumber = 10; >> private static int red

Re: RFR: 8245446: vmTestbase/nsk/jvmti/RedefineClasses/StressRedefine/TestDescription.java crash intermittently

2020-12-08 Thread Serguei Spitsyn
On Tue, 8 Dec 2020 21:01:07 GMT, Chris Plummer wrote: >> The StressRedefine.java (base for redefine stress tests) defines 3 important >> constants: >> private static int staticMethodCallersNumber = 10; >> private static int nonstaticMethodCallersNumber = 10; >> private static int red

Re: RFR: 8245446: vmTestbase/nsk/jvmti/RedefineClasses/StressRedefine/TestDescription.java crash intermittently

2020-12-08 Thread Leonid Mesnik
On Tue, 8 Dec 2020 09:53:36 GMT, Serguei Spitsyn wrote: > The StressRedefine.java (base for redefine stress tests) defines 3 important > constants: > private static int staticMethodCallersNumber = 10; > private static int nonstaticMethodCallersNumber = 10; > private static int redefi

Re: RFR: 8245446: vmTestbase/nsk/jvmti/RedefineClasses/StressRedefine/TestDescription.java crash intermittently

2020-12-08 Thread Chris Plummer
On Tue, 8 Dec 2020 09:53:36 GMT, Serguei Spitsyn wrote: > The StressRedefine.java (base for redefine stress tests) defines 3 important > constants: > private static int staticMethodCallersNumber = 10; > private static int nonstaticMethodCallersNumber = 10; > private static int redefi