Re: RFR: 8246774: Record Classes (final) implementation [v3]

2020-09-29 Thread Jan Lahoda
On Fri, 25 Sep 2020 15:47:30 GMT, Peter Levart wrote: >> [CSR: Record Classes](https://bugs.openjdk.java.net/browse/JDK-8253605) > > Hi @vicente-romero-oracle , note that besides tests, there is also a JMH > benchmark that measures the performance of > records deserialization (org.openjdk.bench.

Re: RFR: 8246774: Record Classes (final) implementation [v3]

2020-09-25 Thread Peter Levart
On Fri, 25 Sep 2020 02:38:01 GMT, Vicente Romero wrote: >> I have modified the `@since`: 14 -> 16 > > [CSR: Record Classes](https://bugs.openjdk.java.net/browse/JDK-8253605) Hi @vicente-romero-oracle , note that besides tests, there is also a JMH benchmark that measures the performance of recor

Re: RFR: 8246774: Record Classes (final) implementation [v3]

2020-09-24 Thread Vicente Romero
On Thu, 24 Sep 2020 15:45:22 GMT, Vicente Romero wrote: >> The classfile parser changes look good to me. > > I have modified the `@since`: 14 -> 16 [CSR: Record Classes](https://bugs.openjdk.java.net/browse/JDK-8253605) - PR: https://git.openjdk.java.net/jdk/pull/290

Re: RFR: 8246774: Record Classes (final) implementation [v3]

2020-09-24 Thread Vicente Romero
On Thu, 24 Sep 2020 12:23:13 GMT, Coleen Phillimore wrote: >> Vicente Romero has updated the pull request incrementally with three >> additional commits since the last revision: >> >> - Merge pull request #1 from ChrisHegarty/record-serial-tests >> >>Remove preview args from JDK tests

Re: RFR: 8246774: Record Classes (final) implementation [v3]

2020-09-24 Thread Coleen Phillimore
On Wed, 23 Sep 2020 03:34:29 GMT, Vicente Romero wrote: >> Co-authored-by: Vicente Romero >> Co-authored-by: Harold Seigel >> Co-authored-by: Jonathan Gibbons >> Co-authored-by: Brian Goetz >> Co-authored-by: Maurizio Cimadamore >> Co-authored-by: Joe Darcy >> Co-authored-by: Chris Hegarty

Re: RFR: 8246774: Record Classes (final) implementation [v3]

2020-09-22 Thread Vicente Romero
> Co-authored-by: Vicente Romero > Co-authored-by: Harold Seigel > Co-authored-by: Jonathan Gibbons > Co-authored-by: Brian Goetz > Co-authored-by: Maurizio Cimadamore > Co-authored-by: Joe Darcy > Co-authored-by: Chris Hegarty > Co-authored-by: Jan Lahoda Vicente Romero has updated the pu