Re: RFR: 8251835: 8251374 breaks jmap -dump:all(Internet mail)

2020-08-14 Thread 臧琳
Dear All, Sorry for making incomplete patch. And thanks for help fixing it. BRs, Lin > On Aug 15, 2020, at 6:04 AM, "serguei.spit...@oracle.com" > wrote: > > Hi Stefan and Paul, > > Thank you for taking care and fixing this regression! > > It seems, the fix from Paul is more comple

Re: RFR: 8251835: 8251374 breaks jmap -dump:all

2020-08-14 Thread serguei.spit...@oracle.com
Hi Stefan and Paul, Thank you for taking care and fixing this regression! It seems, the fix from Paul is more complete and is better to push after testing. It looks good to me. Unfortunately, there is very limited test coverage for this. Thanks, Serguei On 8/14/20 09:47, Stefan Karlsson wr

Re: RFR: 8251835: 8251374 breaks jmap -dump:all

2020-08-14 Thread Stefan Karlsson
On 2020-08-14 18:39, Hohensee, Paul wrote: Makes sense to me to do a followup. I've filed https://bugs.openjdk.java.net/browse/JDK-8251848. Great. I ran TEST="test/jdk/sun/tools/jmap/BasicJMapTest.java" JTREG="JAVA_OPTIONS=-XX:+UseParallelGC -XX:ParallelGCThreads=100" successfully, includi

RE: RFR: 8251835: 8251374 breaks jmap -dump:all

2020-08-14 Thread Hohensee, Paul
Makes sense to me to do a followup. I've filed https://bugs.openjdk.java.net/browse/JDK-8251848. I ran TEST="test/jdk/sun/tools/jmap/BasicJMapTest.java" JTREG="JAVA_OPTIONS=-XX:+UseParallelGC -XX:ParallelGCThreads=100" successfully, including your patch for 8251570. This 8251835 patch looks go

RFR: 8251835: 8251374 breaks jmap -dump:all

2020-08-14 Thread Stefan Karlsson
Hi all, Please review this patch to fix a recently introduced jmap bug. https://cr.openjdk.java.net/~stefank/8251835/webrev.01/ https://bugs.openjdk.java.net/browse/JDK-8251835 I added the same kind of checks that we have in histo. Testing: - Tested locally with the failing test - Tier1-tier5