Re: RFR: 8255381: com/sun/jdi/EATests.java should not suspend graal threads [v3]

2020-12-15 Thread Richard Reingruber
On Fri, 11 Dec 2020 08:43:16 GMT, Richard Reingruber wrote: >> Marked as reviewed by cjplummer (Reviewer). > > @plummercj, @sspitsyn, thanks again for the review. > > I would like to bring the fix to jdk16. According to > https://openjdk.java.net/jeps/3 this is possible in RDP1 for test bug fix

Re: RFR: 8255381: com/sun/jdi/EATests.java should not suspend graal threads [v3]

2020-12-11 Thread Richard Reingruber
On Tue, 8 Dec 2020 19:25:30 GMT, Chris Plummer wrote: >> Richard Reingruber has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Only main thread needs to be resumed in >> EARelockingObjectCurrentlyWaitingOn. > > Marked as reviewed by cjplum

Re: RFR: 8255381: com/sun/jdi/EATests.java should not suspend graal threads [v3]

2020-12-10 Thread Richard Reingruber
On Thu, 10 Dec 2020 02:08:38 GMT, Serguei Spitsyn wrote: >> Richard Reingruber has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Only main thread needs to be resumed in >> EARelockingObjectCurrentlyWaitingOn. > > Hi Richard, > The fix loo

Re: RFR: 8255381: com/sun/jdi/EATests.java should not suspend graal threads [v3]

2020-12-09 Thread Serguei Spitsyn
On Tue, 8 Dec 2020 14:00:25 GMT, Richard Reingruber wrote: >> This fixes a bug in the test test/jdk/com/sun/jdi/EATests.java that caused >> timeout failures when graal is enabled. >> >> The fix is to avoid suspending all threads when a breakpoint is reached and >> then resume >> just the main t

Re: RFR: 8255381: com/sun/jdi/EATests.java should not suspend graal threads [v3]

2020-12-08 Thread Richard Reingruber
On Tue, 8 Dec 2020 19:25:30 GMT, Chris Plummer wrote: >> Richard Reingruber has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Only main thread needs to be resumed in >> EARelockingObjectCurrentlyWaitingOn. > > Marked as reviewed by cjplum

Re: RFR: 8255381: com/sun/jdi/EATests.java should not suspend graal threads [v3]

2020-12-08 Thread Chris Plummer
On Tue, 8 Dec 2020 14:00:25 GMT, Richard Reingruber wrote: >> This fixes a bug in the test test/jdk/com/sun/jdi/EATests.java that caused >> timeout failures when graal is enabled. >> >> The fix is to avoid suspending all threads when a breakpoint is reached and >> then resume >> just the main t

Re: RFR: 8255381: com/sun/jdi/EATests.java should not suspend graal threads [v3]

2020-12-08 Thread Richard Reingruber
> This fixes a bug in the test test/jdk/com/sun/jdi/EATests.java that caused > timeout failures when graal is enabled. > > The fix is to avoid suspending all threads when a breakpoint is reached and > then resume > just the main thread again. This pattern was used in the test case > EAMaterialize