Re: RFR: 8255455: Refactor ThreadHeapSampler::_log_table as constexpr [v2]

2020-10-28 Thread Claes Redestad
On Tue, 27 Oct 2020 23:08:21 GMT, Ioi Lam wrote: >> Claes Redestad has updated the pull request with a new target base due to a >> merge or a rebase. The incremental webrev excludes the unrelated changes >> brought in by the merge/rebase. The pull request contains three additional >> commits s

Re: RFR: 8255455: Refactor ThreadHeapSampler::_log_table as constexpr [v2]

2020-10-28 Thread Claes Redestad
On Tue, 27 Oct 2020 23:08:13 GMT, Ioi Lam wrote: >> Claes Redestad has updated the pull request with a new target base due to a >> merge or a rebase. The incremental webrev excludes the unrelated changes >> brought in by the merge/rebase. The pull request contains three additional >> commits s

Re: RFR: 8255455: Refactor ThreadHeapSampler::_log_table as constexpr [v2]

2020-10-27 Thread Ioi Lam
On Tue, 27 Oct 2020 14:56:33 GMT, Claes Redestad wrote: >> The static `ThreadHeapSampler::_log_table` is currently initialized on JVM >> bootstrap to an overhead of ~67k instructions (linux-x64). By turning the >> initialization into a constexpr, we can precalculate the helper table at >> comp

Re: RFR: 8255455: Refactor ThreadHeapSampler::_log_table as constexpr [v2]

2020-10-27 Thread Claes Redestad
> The static `ThreadHeapSampler::_log_table` is currently initialized on JVM > bootstrap to an overhead of ~67k instructions (linux-x64). By turning the > initialization into a constexpr, we can precalculate the helper table at > compile time, which trades a runtime overhead for a small, 8kb, st