Re: RFR: 8256181: Remove Allocation of old generation on alternate memory devices functionality [v2]

2020-11-12 Thread Thomas Schatzl
On Wed, 11 Nov 2020 15:19:05 GMT, Albert Mingkun Yang wrote: >> Thomas Schatzl has updated the pull request incrementally with one >> additional commit since the last revision: >> >> ayang review > > A general comment for future PRs: I think it's best to isolate mechanical > changes into the

Re: RFR: 8256181: Remove Allocation of old generation on alternate memory devices functionality [v2]

2020-11-11 Thread Ioi Lam
On Wed, 11 Nov 2020 15:38:10 GMT, Thomas Schatzl wrote: >> Hi all, >> >> can I get reviews for this change that removes the "Allocation of old >> generation of Java heap on alternate memory devices" functionality >> introduced with JDK 12 with >> [JDK-8202286](https://bugs.openjdk.java.net/

Re: RFR: 8256181: Remove Allocation of old generation on alternate memory devices functionality [v2]

2020-11-11 Thread Igor Ignatyev
On Wed, 11 Nov 2020 15:38:10 GMT, Thomas Schatzl wrote: >> Hi all, >> >> can I get reviews for this change that removes the "Allocation of old >> generation of Java heap on alternate memory devices" functionality >> introduced with JDK 12 with >> [JDK-8202286](https://bugs.openjdk.java.net/

Re: RFR: 8256181: Remove Allocation of old generation on alternate memory devices functionality [v2]

2020-11-11 Thread Ioi Lam
On Wed, 11 Nov 2020 15:19:05 GMT, Albert Mingkun Yang wrote: >> Thomas Schatzl has updated the pull request incrementally with one >> additional commit since the last revision: >> >> ayang review > > A general comment for future PRs: I think it's best to isolate mechanical > changes into the

Re: RFR: 8256181: Remove Allocation of old generation on alternate memory devices functionality [v2]

2020-11-11 Thread Thomas Schatzl
On Wed, 11 Nov 2020 15:09:44 GMT, Albert Mingkun Yang wrote: >> Thomas Schatzl has updated the pull request incrementally with one >> additional commit since the last revision: >> >> ayang review > > test/hotspot/jtreg/TEST.ROOT line 78: > >> 76: vm.musl \ >> 77: docker.support \ >>

Re: RFR: 8256181: Remove Allocation of old generation on alternate memory devices functionality [v2]

2020-11-11 Thread Thomas Schatzl
> Hi all, > > can I get reviews for this change that removes the "Allocation of old > generation of Java heap on alternate memory devices" functionality introduced > with JDK 12 with > [JDK-8202286](https://bugs.openjdk.java.net/browse/JDK-8202286) due to being > > - not used by anyone > - n

Re: RFR: 8256181: Remove Allocation of old generation on alternate memory devices functionality

2020-11-11 Thread Albert Mingkun Yang
On Wed, 11 Nov 2020 11:11:25 GMT, Thomas Schatzl wrote: > Hi all, > > can I get reviews for this change that removes the "Allocation of old > generation of Java heap on alternate memory devices" functionality introduced > with JDK 12 with > [JDK-8202286](https://bugs.openjdk.java.net/browse

Re: RFR: 8256181: Remove Allocation of old generation on alternate memory devices functionality

2020-11-11 Thread Thomas Stüfe
Hi Thomas, I think this makes sense. Just a question, how are your thoughts about JEP316? Do you consider AllocateHeapAt similarly unused? Cheers, Thomas On Wed, Nov 11, 2020 at 2:17 PM Thomas Schatzl wrote: > Hi all, > > can I get reviews for this change that removes the "Allocation of old

RFR: 8256181: Remove Allocation of old generation on alternate memory devices functionality

2020-11-11 Thread Thomas Schatzl
Hi all, can I get reviews for this change that removes the "Allocation of old generation of Java heap on alternate memory devices" functionality introduced with JDK 12 with [JDK-8202286](https://bugs.openjdk.java.net/browse/JDK-8202286) due to being - not used by anyone - not maintained by a