On Wed, 27 Jan 2021 20:41:50 GMT, Daniel D. Daugherty
wrote:
>> The number should be small. I typically see 2 or 3 depending on the java
>> options. If I happen to see more, then that's a clue (to me anyway) that
>> something has changed and might be amiss.
>
> I ran this patch thru Mach5 Tier[1
On Wed, 27 Jan 2021 14:17:22 GMT, Daniel D. Daugherty
wrote:
>>> I thought the comments regarding the test were to use an if statement to
>>> check iter.hasNext() and return after seeing one Monitor, rather than
>>> keeping the while-loop and reporting every single Monitor found. The latter
>
On Wed, 27 Jan 2021 05:41:47 GMT, Yasumasa Suenaga wrote:
>> Hi Yasumasa,
>>
>> I thought the comments regarding the test were to use an if statement to
>> check iter.hasNext() and return after seeing one Monitor, rather than
>> keeping the while-loop and reporting every single Monitor found.
On 27/01/2021 3:44 pm, Yasumasa Suenaga wrote:
On Wed, 27 Jan 2021 04:51:04 GMT, David Holmes wrote:
I thought the comments regarding the test were to use an if statement to check
iter.hasNext() and return after seeing one Monitor, rather than keeping the
while-loop and reporting every singl
On Wed, 27 Jan 2021 04:51:04 GMT, David Holmes wrote:
> I thought the comments regarding the test were to use an if statement to
> check iter.hasNext() and return after seeing one Monitor, rather than keeping
> the while-loop and reporting every single Monitor found. The latter seems a
> waste
On Wed, 27 Jan 2021 00:59:59 GMT, Yasumasa Suenaga wrote:
>> I saw the exception as following when I chose "Monitor Cache Dump" menu on
>> HSDB:
>>
>> Exception in thread "AWT-EventQueue-0" java.lang.ExceptionInInitializerError
>> at
>> jdk.hotspot.agent/sun.jvm.hotspot.ui.MonitorCache
On Wed, 27 Jan 2021 03:46:32 GMT, Serguei Spitsyn wrote:
>> Yasumasa Suenaga has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Update testcase
>
> LGTM++
> Thanks,
> Serguei
Thank you for the review!
> What test has been done with the la
On Wed, 27 Jan 2021 00:59:59 GMT, Yasumasa Suenaga wrote:
>> I saw the exception as following when I chose "Monitor Cache Dump" menu on
>> HSDB:
>>
>> Exception in thread "AWT-EventQueue-0" java.lang.ExceptionInInitializerError
>> at
>> jdk.hotspot.agent/sun.jvm.hotspot.ui.MonitorCache
On Wed, 27 Jan 2021 00:59:59 GMT, Yasumasa Suenaga wrote:
>> I saw the exception as following when I chose "Monitor Cache Dump" menu on
>> HSDB:
>>
>> Exception in thread "AWT-EventQueue-0" java.lang.ExceptionInInitializerError
>> at
>> jdk.hotspot.agent/sun.jvm.hotspot.ui.MonitorCache
On Wed, 27 Jan 2021 00:59:59 GMT, Yasumasa Suenaga wrote:
>> I saw the exception as following when I chose "Monitor Cache Dump" menu on
>> HSDB:
>>
>> Exception in thread "AWT-EventQueue-0" java.lang.ExceptionInInitializerError
>> at
>> jdk.hotspot.agent/sun.jvm.hotspot.ui.MonitorCache
On Tue, 26 Jan 2021 02:14:34 GMT, Chris Plummer wrote:
>> Yasumasa Suenaga has updated the pull request with a new target base due to
>> a merge or a rebase. The pull request now contains seven commits:
>>
>> - Update comments for ObjectMonitorIterator
>> - Merge remote-tracking branch 'upstr
> I saw the exception as following when I chose "Monitor Cache Dump" menu on
> HSDB:
>
> Exception in thread "AWT-EventQueue-0" java.lang.ExceptionInInitializerError
> at
> jdk.hotspot.agent/sun.jvm.hotspot.ui.MonitorCacheDumpPanel.dumpOn(MonitorCacheDumpPanel.java:92)
> at
> jd
On Tue, 26 Jan 2021 08:29:03 GMT, Yasumasa Suenaga wrote:
>> I saw the exception as following when I chose "Monitor Cache Dump" menu on
>> HSDB:
>>
>> Exception in thread "AWT-EventQueue-0" java.lang.ExceptionInInitializerError
>> at
>> jdk.hotspot.agent/sun.jvm.hotspot.ui.MonitorCache
On Sat, 23 Jan 2021 03:25:49 GMT, Yasumasa Suenaga wrote:
>> test/hotspot/jtreg/serviceability/sa/TestObjectMonitorIterate.java line 78:
>>
>>> 76: SATestUtils.addPrivilegesIfNeeded(processBuilder);
>>> 77: OutputAnalyzer SAOutput =
>>> ProcessTools.executeProcess(processBuilder
On Tue, 26 Jan 2021 08:23:28 GMT, Serguei Spitsyn wrote:
>> I'd say that's a bug, and probably what was meant is to do a `println` for
>> every monitor found, not just the first one. So what you would want then is
>> to bracket the `while` loop with `if (itr.hasNext()) {` and move the
>> `retu
On Tue, 26 Jan 2021 07:54:35 GMT, Chris Plummer wrote:
>> Hi Yasumasa,
>>
>> It looks good to me.
>> I have one minor question.
>>
>> This loop in the test is a little bit confusing as it has not more than one
>> iteration:
>> 55 while (itr.hasNext()) {
>> 56 Object
> I saw the exception as following when I chose "Monitor Cache Dump" menu on
> HSDB:
>
> Exception in thread "AWT-EventQueue-0" java.lang.ExceptionInInitializerError
> at
> jdk.hotspot.agent/sun.jvm.hotspot.ui.MonitorCacheDumpPanel.dumpOn(MonitorCacheDumpPanel.java:92)
> at
> jd
On Tue, 26 Jan 2021 07:44:19 GMT, Serguei Spitsyn wrote:
>> Yasumasa Suenaga has updated the pull request with a new target base due to
>> a merge or a rebase. The pull request now contains seven commits:
>>
>> - Update comments for ObjectMonitorIterator
>> - Merge remote-tracking branch 'ups
On Tue, 26 Jan 2021 00:31:56 GMT, Yasumasa Suenaga wrote:
>> I saw the exception as following when I chose "Monitor Cache Dump" menu on
>> HSDB:
>>
>> Exception in thread "AWT-EventQueue-0" java.lang.ExceptionInInitializerError
>> at
>> jdk.hotspot.agent/sun.jvm.hotspot.ui.MonitorCache
On Tue, 26 Jan 2021 00:31:56 GMT, Yasumasa Suenaga wrote:
>> I saw the exception as following when I chose "Monitor Cache Dump" menu on
>> HSDB:
>>
>> Exception in thread "AWT-EventQueue-0" java.lang.ExceptionInInitializerError
>> at
>> jdk.hotspot.agent/sun.jvm.hotspot.ui.MonitorCache
> I saw the exception as following when I chose "Monitor Cache Dump" menu on
> HSDB:
>
> Exception in thread "AWT-EventQueue-0" java.lang.ExceptionInInitializerError
> at
> jdk.hotspot.agent/sun.jvm.hotspot.ui.MonitorCacheDumpPanel.dumpOn(MonitorCacheDumpPanel.java:92)
> at
> jd
On Mon, 25 Jan 2021 23:07:39 GMT, Chris Plummer wrote:
>> inUseList only contains ObjectMonitors. No raw monitors (JVM/TI or otherwise)
>> are managed on that list.
>
> Ok, then I think this comment needs to be retained.
I reverted comment, and update it.
-
PR: https://git.openjdk.
On Mon, 25 Jan 2021 22:38:38 GMT, Daniel D. Daugherty
wrote:
>> src/jdk.hotspot.agent/share/classes/sun/jvm/hotspot/runtime/ObjectSynchronizer.java
>> line 97:
>>
>>> 95: }
>>> 96: mon = new ObjectMonitor(monAddr);
>>> 97: return mon;
>>
>> Are JVMTI raw monitors now in the
On Mon, 25 Jan 2021 22:28:08 GMT, Chris Plummer wrote:
>> Yasumasa Suenaga has updated the pull request incrementally with two
>> additional commits since the last revision:
>>
>> - Update copyright year
>> - Remove unused code
>
> src/jdk.hotspot.agent/share/classes/sun/jvm/hotspot/runtime/O
On Sat, 23 Jan 2021 03:23:58 GMT, Yasumasa Suenaga wrote:
>> I saw the exception as following when I chose "Monitor Cache Dump" menu on
>> HSDB:
>>
>> Exception in thread "AWT-EventQueue-0" java.lang.ExceptionInInitializerError
>> at
>> jdk.hotspot.agent/sun.jvm.hotspot.ui.MonitorCache
On Mon, 25 Jan 2021 22:02:07 GMT, Daniel D. Daugherty
wrote:
> @sspitsyn or @plummercj - I haven't seen anyone from Serviceability
> chime in on this review thread...
I took a quick look earlier today. It seemed to mostly be dependent on hotspot
knowledge I don't have. I'll look at the SA spec
On Sat, 23 Jan 2021 03:23:58 GMT, Yasumasa Suenaga wrote:
>> I saw the exception as following when I chose "Monitor Cache Dump" menu on
>> HSDB:
>>
>> Exception in thread "AWT-EventQueue-0" java.lang.ExceptionInInitializerError
>> at
>> jdk.hotspot.agent/sun.jvm.hotspot.ui.MonitorCache
On Mon, 25 Jan 2021 21:59:38 GMT, Daniel D. Daugherty
wrote:
>> Yasumasa Suenaga has updated the pull request incrementally with two
>> additional commits since the last revision:
>>
>> - Update copyright year
>> - Remove unused code
>
> Thumbs up.
@sspitsyn or @plummercj - I haven't seen a
On Sat, 23 Jan 2021 03:23:58 GMT, Yasumasa Suenaga wrote:
>> I saw the exception as following when I chose "Monitor Cache Dump" menu on
>> HSDB:
>>
>> Exception in thread "AWT-EventQueue-0" java.lang.ExceptionInInitializerError
>> at
>> jdk.hotspot.agent/sun.jvm.hotspot.ui.MonitorCache
On Sat, 23 Jan 2021 03:23:58 GMT, Yasumasa Suenaga wrote:
>> I saw the exception as following when I chose "Monitor Cache Dump" menu on
>> HSDB:
>>
>> Exception in thread "AWT-EventQueue-0" java.lang.ExceptionInInitializerError
>> at
>> jdk.hotspot.agent/sun.jvm.hotspot.ui.MonitorCache
On Mon, 25 Jan 2021 15:26:59 GMT, Gerard Ziemski wrote:
>> Yasumasa Suenaga has updated the pull request incrementally with two
>> additional commits since the last revision:
>>
>> - Update copyright year
>> - Remove unused code
>
> Marked as reviewed by gziemski (Committer).
Thank you Yasum
On Fri, 22 Jan 2021 18:00:09 GMT, Daniel D. Daugherty
wrote:
>> Yasumasa Suenaga has updated the pull request with a new target base due to
>> a merge or a rebase. The pull request now contains three commits:
>>
>> - Fix comments
>> - Merge
>> - 8259008: ArithmeticException was thrown at "M
> I saw the exception as following when I chose "Monitor Cache Dump" menu on
> HSDB:
>
> Exception in thread "AWT-EventQueue-0" java.lang.ExceptionInInitializerError
> at
> jdk.hotspot.agent/sun.jvm.hotspot.ui.MonitorCacheDumpPanel.dumpOn(MonitorCacheDumpPanel.java:92)
> at
> jd
On Fri, 22 Jan 2021 18:05:15 GMT, Daniel D. Daugherty
wrote:
>> Yasumasa Suenaga has updated the pull request with a new target base due to
>> a merge or a rebase. The pull request now contains three commits:
>>
>> - Fix comments
>> - Merge
>> - 8259008: ArithmeticException was thrown at "M
On Tue, 19 Jan 2021 08:58:10 GMT, Yasumasa Suenaga wrote:
>> I saw the exception as following when I chose "Monitor Cache Dump" menu on
>> HSDB:
>>
>> Exception in thread "AWT-EventQueue-0" java.lang.ExceptionInInitializerError
>> at
>> jdk.hotspot.agent/sun.jvm.hotspot.ui.MonitorCache
On Tue, 19 Jan 2021 08:58:10 GMT, Yasumasa Suenaga wrote:
>> I saw the exception as following when I chose "Monitor Cache Dump" menu on
>> HSDB:
>>
>> Exception in thread "AWT-EventQueue-0" java.lang.ExceptionInInitializerError
>> at
>> jdk.hotspot.agent/sun.jvm.hotspot.ui.MonitorCache
On Thu, 21 Jan 2021 18:36:00 GMT, Gerard Ziemski wrote:
>> Thanks @dholmes-ora for the comment and review!
>> I fixed them in new commit.
>>
>> I wait the review from @dcubed-ojdk .
>
> Hi Yasumasa,
>
> Just to let you know, I'm taking a look at your fix...
I'm taking a look now... We should a
On Tue, 19 Jan 2021 08:55:01 GMT, Yasumasa Suenaga wrote:
>> Hi Yasumasa,
>>
>> So this makes MonitorList, MonitorList::Iterator and
>> ObjectSynchronizer::_in_use_list, exported top-level entities so that SA can
>> use them as a replacement for the old gBlockList. This seems quite
>> reasona
> I saw the exception as following when I chose "Monitor Cache Dump" menu on
> HSDB:
>
> Exception in thread "AWT-EventQueue-0" java.lang.ExceptionInInitializerError
> at
> jdk.hotspot.agent/sun.jvm.hotspot.ui.MonitorCacheDumpPanel.dumpOn(MonitorCacheDumpPanel.java:92)
> at
> jd
On Tue, 19 Jan 2021 06:27:27 GMT, David Holmes wrote:
>> Yasumasa Suenaga has updated the pull request with a new target base due to
>> a merge or a rebase. The pull request now contains three commits:
>>
>> - Fix comments
>> - Merge
>> - 8259008: ArithmeticException was thrown at "Monitor C
On Wed, 30 Dec 2020 13:51:04 GMT, Yasumasa Suenaga wrote:
> I saw the exception as following when I chose "Monitor Cache Dump" menu on
> HSDB:
>
> Exception in thread "AWT-EventQueue-0" java.lang.ExceptionInInitializerError
> at
> jdk.hotspot.agent/sun.jvm.hotspot.ui.MonitorCacheDumpPa
On Wed, 30 Dec 2020 13:51:04 GMT, Yasumasa Suenaga wrote:
> I saw the exception as following when I chose "Monitor Cache Dump" menu on
> HSDB:
>
> Exception in thread "AWT-EventQueue-0" java.lang.ExceptionInInitializerError
> at
> jdk.hotspot.agent/sun.jvm.hotspot.ui.MonitorCacheDumpPa
I saw the exception as following when I chose "Monitor Cache Dump" menu on HSDB:
Exception in thread "AWT-EventQueue-0" java.lang.ExceptionInInitializerError
at
jdk.hotspot.agent/sun.jvm.hotspot.ui.MonitorCacheDumpPanel.dumpOn(MonitorCacheDumpPanel.java:92)
at
jdk.hotspot.agent/s
43 matches
Mail list logo
