On Fri, 19 Mar 2021 05:39:25 GMT, Ioi Lam wrote:
>> Yumin Qi has updated the pull request with a new target base due to a merge
>> or a rebase. The incremental webrev excludes the unrelated changes brought
>> in by the merge/rebase. The pull request contains five additional commits
>> since th
On Thu, 11 Mar 2021 04:03:29 GMT, Yumin Qi wrote:
>> Hi, Please review
>>
>> Added jcmd option for dumping CDS archive during application runtime.
>> Before this change, user has to dump shared archive in two steps: first run
>> application with
>> `java -XX:DumpLoadedClassList= `
>
On Fri, 26 Feb 2021 22:46:07 GMT, Ioi Lam wrote:
>> Yumin Qi has updated the pull request with a new target base due to a merge
>> or a rebase. The incremental webrev excludes the unrelated changes brought
>> in by the merge/rebase. The pull request contains five additional commits
>> since th
On Fri, 26 Feb 2021 22:01:50 GMT, Calvin Cheung wrote:
>> Yumin Qi has updated the pull request with a new target base due to a merge
>> or a rebase. The incremental webrev excludes the unrelated changes brought
>> in by the merge/rebase. The pull request contains five additional commits
>> si
On Sat, 27 Feb 2021 18:11:38 GMT, Ioi Lam wrote:
>> How would it overflow? But I agree, I would not add jsa extension if the
>> user did not specify one. I dislike when programs do that.
>
> `file_name` is user input that comes from the jcmd, so it can be arbitrarily
> long and exceed JVM_MAXPA
On Sat, 27 Feb 2021 05:12:25 GMT, Thomas Stuefe wrote:
>> src/hotspot/share/memory/metaspaceShared.cpp line 783:
>>
>>> 781: char* start = buffer + strlen(buffer);
>>> 782: snprintf(start, buff_len, "%s ", arg);
>>> 783: }
>>
>> Maybe move the above function to the StringUtils class under s
On Fri, 26 Feb 2021 21:39:48 GMT, Ioi Lam wrote:
>> Yumin Qi has updated the pull request with a new target base due to a merge
>> or a rebase. The incremental webrev excludes the unrelated changes brought
>> in by the merge/rebase. The pull request contains five additional commits
>> since th
> Hi, Please review
>
> Added jcmd option for dumping CDS archive during application runtime.
> Before this change, user has to dump shared archive in two steps: first run
> application with
> `java -XX:DumpLoadedClassList= `
> to collect shareable class names and saved in file `` ,
