Re: RFR: 8269466: Factor out the common code for initializing and starting internal VM JavaThreads [v3]

2021-07-01 Thread David Holmes
On Thu, 1 Jul 2021 12:07:10 GMT, Coleen Phillimore wrote: >> David Holmes has updated the pull request incrementally with three >> additional commits since the last revision: >> >> - Rename vm_exit_on_thread_allocation_failure to vm_exit_on_osthread_failure >> - Adjust comment >> - Comments

Re: RFR: 8269466: Factor out the common code for initializing and starting internal VM JavaThreads [v3]

2021-07-01 Thread David Holmes
On 2/07/2021 3:36 am, Coleen Phillimore wrote: On Thu, 1 Jul 2021 16:14:22 GMT, Vladimir Kozlov wrote: David Holmes has updated the pull request incrementally with three additional commits since the last revision: - Rename vm_exit_on_thread_allocation_failure to vm_exit_on_osthread_failure

Re: RFR: 8269466: Factor out the common code for initializing and starting internal VM JavaThreads [v3]

2021-07-01 Thread Vladimir Kozlov
On Thu, 1 Jul 2021 22:02:40 GMT, David Holmes wrote: >> src/hotspot/share/compiler/compileBroker.cpp line 939: >> >>> 937: && comp->num_compiler_threads() > 0) { >>> 938: // The new thread is not known to Thread-SMR yet so we can just >>> delete. >>> 939: delete new_thread;

Re: RFR: 8269466: Factor out the common code for initializing and starting internal VM JavaThreads [v3]

2021-07-01 Thread David Holmes
Thanks for the review Serguei! David On 2/07/2021 2:30 am, Serguei Spitsyn wrote: On Thu, 1 Jul 2021 04:18:28 GMT, David Holmes wrote: Please see the JBS issue for more details, but basically we have 8 different kinds of internal VM JavaThreads (grouping the three types of CompilerThread t

Re: RFR: 8269466: Factor out the common code for initializing and starting internal VM JavaThreads [v3]

2021-07-01 Thread David Holmes
On Thu, 1 Jul 2021 17:33:02 GMT, Coleen Phillimore wrote: >> src/hotspot/share/compiler/compileBroker.cpp line 909: >> >>> 907: // JavaThread due to lack of resources. We will handle that failure >>> below. >>> 908: >>> 909: if (new_thread->osthread() != NULL) { >> >> I think you do need

Re: RFR: 8269466: Factor out the common code for initializing and starting internal VM JavaThreads [v3]

2021-07-01 Thread David Holmes
On Thu, 1 Jul 2021 16:18:50 GMT, Vladimir Kozlov wrote: >> David Holmes has updated the pull request incrementally with three >> additional commits since the last revision: >> >> - Rename vm_exit_on_thread_allocation_failure to vm_exit_on_osthread_failure >> - Adjust comment >> - Comments fr

Re: RFR: 8269466: Factor out the common code for initializing and starting internal VM JavaThreads [v3]

2021-07-01 Thread Coleen Phillimore
On Thu, 1 Jul 2021 16:14:22 GMT, Vladimir Kozlov wrote: >> David Holmes has updated the pull request incrementally with three >> additional commits since the last revision: >> >> - Rename vm_exit_on_thread_allocation_failure to vm_exit_on_osthread_failure >> - Adjust comment >> - Comments fr

Re: RFR: 8269466: Factor out the common code for initializing and starting internal VM JavaThreads [v3]

2021-07-01 Thread Daniel D . Daugherty
On Thu, 1 Jul 2021 04:18:28 GMT, David Holmes wrote: >> Please see the JBS issue for more details, but basically we have 8 different >> kinds of internal VM JavaThreads (grouping the three types of CompilerThread >> together) that all basically duplicated the logic for initializing >> (prepari

Re: RFR: 8269466: Factor out the common code for initializing and starting internal VM JavaThreads [v3]

2021-07-01 Thread Serguei Spitsyn
On Thu, 1 Jul 2021 04:18:28 GMT, David Holmes wrote: >> Please see the JBS issue for more details, but basically we have 8 different >> kinds of internal VM JavaThreads (grouping the three types of CompilerThread >> together) that all basically duplicated the logic for initializing >> (prepari

Re: RFR: 8269466: Factor out the common code for initializing and starting internal VM JavaThreads [v3]

2021-07-01 Thread Vladimir Kozlov
On Thu, 1 Jul 2021 04:18:28 GMT, David Holmes wrote: >> Please see the JBS issue for more details, but basically we have 8 different >> kinds of internal VM JavaThreads (grouping the three types of CompilerThread >> together) that all basically duplicated the logic for initializing >> (prepari

Re: RFR: 8269466: Factor out the common code for initializing and starting internal VM JavaThreads [v3]

2021-07-01 Thread Coleen Phillimore
On Thu, 1 Jul 2021 04:18:28 GMT, David Holmes wrote: >> Please see the JBS issue for more details, but basically we have 8 different >> kinds of internal VM JavaThreads (grouping the three types of CompilerThread >> together) that all basically duplicated the logic for initializing >> (prepari

Re: RFR: 8269466: Factor out the common code for initializing and starting internal VM JavaThreads [v3]

2021-07-01 Thread Coleen Phillimore
On Thu, 1 Jul 2021 04:18:28 GMT, David Holmes wrote: >> Please see the JBS issue for more details, but basically we have 8 different >> kinds of internal VM JavaThreads (grouping the three types of CompilerThread >> together) that all basically duplicated the logic for initializing >> (prepari

Re: RFR: 8269466: Factor out the common code for initializing and starting internal VM JavaThreads [v3]

2021-06-30 Thread David Holmes
> Please see the JBS issue for more details, but basically we have 8 different > kinds of internal VM JavaThreads (grouping the three types of CompilerThread > together) that all basically duplicated the logic for initializing (preparing > is the term we use for user-defined JavaThreads) and sta