On Fri, 10 Dec 2021 21:05:38 GMT, Alex Menkov wrote:
>> Chris Plummer has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Renamed isRetry to allowRetry.
>
> test/jdk/sun/tools/jhsdb/JShellHeapDumpTest.java line 112:
>
>> 110:
On Fri, 10 Dec 2021 20:30:41 GMT, Chris Plummer wrote:
>> The test searches for "JShellToolProvider" in the main thread's stack trace,
>> which is pulled from an SA heap dump. Typically the main thread is blocked
>> in Object.wait(), so SA can determine its stack trace. However, the wait has
On Fri, 10 Dec 2021 12:22:22 GMT, Serguei Spitsyn wrote:
> Hi Chris,
> It looks good in general. I feel the parameter 'retry' is a little bit
> confusing. It is possible to rename it to some to 'retriedOnce'. Another
> approach would be to name it 'allowRetry' and revert the meaning of boolean
> The test searches for "JShellToolProvider" in the main thread's stack trace,
> which is pulled from an SA heap dump. Typically the main thread is blocked in
> Object.wait(), so SA can determine its stack trace. However, the wait has a
> 100ms timeout, so the thread does periodically wake up
