Re: RFR: 8269652: Factor out the common code for creating system j.l.Thread objects

2021-07-04 Thread David Holmes
On Fri, 2 Jul 2021 07:03:50 GMT, David Holmes wrote: > Please review this simple refactoring to share the common code used to create > j.l.Thread instances for the internal VM JavaThreads. (Also fix a missing > space from my previous change in thread.cpp.) > > It is all very straight-forward.

Re: RFR: 8269652: Factor out the common code for creating system j.l.Thread objects

2021-07-03 Thread Xin Liu
On Fri, 2 Jul 2021 07:03:50 GMT, David Holmes wrote: > Please review this simple refactoring to share the common code used to create > j.l.Thread instances for the internal VM JavaThreads. (Also fix a missing > space from my previous change in thread.cpp.) > > It is all very straight-forward.

Re: RFR: 8269652: Factor out the common code for creating system j.l.Thread objects

2021-07-03 Thread David Holmes
On 3/07/2021 10:40 am, Vladimir Kozlov wrote: On Fri, 2 Jul 2021 07:03:50 GMT, David Holmes wrote: Please review this simple refactoring to share the common code used to create j.l.Thread instances for the internal VM JavaThreads. (Also fix a missing space from my previous change in thread.c

Re: RFR: 8269652: Factor out the common code for creating system j.l.Thread objects

2021-07-03 Thread David Holmes
Hi Xin, Thanks for taking a look at this. On 3/07/2021 1:10 pm, Xin Liu wrote: On Fri, 2 Jul 2021 07:03:50 GMT, David Holmes wrote: Please review this simple refactoring to share the common code used to create j.l.Thread instances for the internal VM JavaThreads. (Also fix a missing space

Re: RFR: 8269652: Factor out the common code for creating system j.l.Thread objects

2021-07-02 Thread Xin Liu
On Fri, 2 Jul 2021 07:03:50 GMT, David Holmes wrote: > Please review this simple refactoring to share the common code used to create > j.l.Thread instances for the internal VM JavaThreads. (Also fix a missing > space from my previous change in thread.cpp.) > > It is all very straight-forward.

Re: RFR: 8269652: Factor out the common code for creating system j.l.Thread objects

2021-07-02 Thread Vladimir Kozlov
On Fri, 2 Jul 2021 07:03:50 GMT, David Holmes wrote: > Please review this simple refactoring to share the common code used to create > j.l.Thread instances for the internal VM JavaThreads. (Also fix a missing > space from my previous change in thread.cpp.) > > It is all very straight-forward.

Re: RFR: 8269652: Factor out the common code for creating system j.l.Thread objects

2021-07-02 Thread David Holmes
On 3/07/2021 7:58 am, Daniel D.Daugherty wrote: On Fri, 2 Jul 2021 07:03:50 GMT, David Holmes wrote: Please review this simple refactoring to share the common code used to create j.l.Thread instances for the internal VM JavaThreads. (Also fix a missing space from my previous change in thread

Re: RFR: 8269652: Factor out the common code for creating system j.l.Thread objects

2021-07-02 Thread David Holmes
On 3/07/2021 4:27 am, Coleen Phillimore wrote: On Fri, 2 Jul 2021 07:03:50 GMT, David Holmes wrote: Please review this simple refactoring to share the common code used to create j.l.Thread instances for the internal VM JavaThreads. (Also fix a missing space from my previous change in thread.

Re: RFR: 8269652: Factor out the common code for creating system j.l.Thread objects

2021-07-02 Thread Daniel D . Daugherty
On Fri, 2 Jul 2021 07:03:50 GMT, David Holmes wrote: > Please review this simple refactoring to share the common code used to create > j.l.Thread instances for the internal VM JavaThreads. (Also fix a missing > space from my previous change in thread.cpp.) > > It is all very straight-forward.

Re: RFR: 8269652: Factor out the common code for creating system j.l.Thread objects

2021-07-02 Thread Coleen Phillimore
On Fri, 2 Jul 2021 07:03:50 GMT, David Holmes wrote: > Please review this simple refactoring to share the common code used to create > j.l.Thread instances for the internal VM JavaThreads. (Also fix a missing > space from my previous change in thread.cpp.) > > It is all very straight-forward.

RFR: 8269652: Factor out the common code for creating system j.l.Thread objects

2021-07-02 Thread David Holmes
Please review this simple refactoring to share the common code used to create j.l.Thread instances for the internal VM JavaThreads. (Also fix a missing space from my previous change in thread.cpp.) It is all very straight-forward. Compiler folk I can go one step further and remove CompileBroke