On Fri, 28 Jan 2022 04:07:40 GMT, Chris Plummer wrote:
>> It's possible for an address to be in the codecache but not in any CodeBlob.
>> Don't assert in this case.
>>
>> Also I ran into a couple of other asserts listed below. It looks like since
>> dumping the threadcontext can result in
On Fri, 28 Jan 2022 04:07:40 GMT, Chris Plummer wrote:
>> It's possible for an address to be in the codecache but not in any CodeBlob.
>> Don't assert in this case.
>>
>> Also I ran into a couple of other asserts listed below. It looks like since
>> dumping the threadcontext can result in
On Wed, 26 Jan 2022 22:50:47 GMT, Serguei Spitsyn wrote:
>> Chris Plummer has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Guard against invalid CodeBlobs that may throw exceptions.
>
> Looks okay to me.
> Thanks,
> Serguei
@sspitsyn
On Fri, 28 Jan 2022 04:07:40 GMT, Chris Plummer wrote:
>> It's possible for an address to be in the codecache but not in any CodeBlob.
>> Don't assert in this case.
>>
>> Also I ran into a couple of other asserts listed below. It looks like since
>> dumping the threadcontext can result in
On Tue, 25 Jan 2022 22:07:37 GMT, Chris Plummer wrote:
> It's possible for an address to be in the codecache but not in any CodeBlob.
> Don't assert in this case.
>
> Also I ran into a couple of other asserts listed below. It looks like since
> dumping the threadcontext can result in using
On Wed, 26 Jan 2022 14:27:54 GMT, Kevin Walls wrote:
>> Chris Plummer has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Guard against invalid CodeBlobs that may throw exceptions.
>
>
> It's possible for an address to be in the codecache but not in any CodeBlob.
> Don't assert in this case.
>
> Also I ran into a couple of other asserts listed below. It looks like since
> dumping the threadcontext can result in using PointerFinder with fairly
> random addresses, it is doing
On Tue, 25 Jan 2022 22:07:37 GMT, Chris Plummer wrote:
> It's possible for an address to be in the codecache but not in any CodeBlob.
> Don't assert in this case.
>
> Note I couldn't reproduce this failure. Not sure why since it seemed to
> reproduce pretty readily in our CI tier7, and I ran
On Tue, 25 Jan 2022 22:07:37 GMT, Chris Plummer wrote:
> It's possible for an address to be in the codecache but not in any CodeBlob.
> Don't assert in this case.
>
> Note I couldn't reproduce this failure. Not sure why since it seemed to
> reproduce pretty readily in our CI tier7, and I ran
It's possible for an address to be in the codecache but not in any CodeBlob.
Don't assert in this case.
Note I couldn't reproduce this failure. Not sure why since it seemed to
reproduce pretty readily in our CI tier7, and I ran with the same options.
-
Commit messages:
- Don't
10 matches
Mail list logo