Re: RFR: 8284330: jcmd may not be able to find processes in the container [v2]

2022-04-08 Thread Yasumasa Suenaga
On Fri, 8 Apr 2022 03:50:10 GMT, Ioi Lam wrote: >> Yasumasa Suenaga has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Fix comments > > The code changes look good, but I think the comment should be cleaned up. Thanks @iklam and @tstuefe !

Re: RFR: 8284330: jcmd may not be able to find processes in the container [v2]

2022-04-07 Thread Thomas Stuefe
On Wed, 6 Apr 2022 12:44:35 GMT, Yasumasa Suenaga wrote: >> jcmd uses >> src/jdk.internal.jvmstat/linux/classes/sun/jvmstat/PlatformSupportImpl.java >> to scan temporary directories to find out processes in the container. It >> checks inode to ensure the temp directory is not conflicted. Howev

Re: RFR: 8284330: jcmd may not be able to find processes in the container [v2]

2022-04-07 Thread Ioi Lam
On Wed, 6 Apr 2022 12:44:35 GMT, Yasumasa Suenaga wrote: >> jcmd uses >> src/jdk.internal.jvmstat/linux/classes/sun/jvmstat/PlatformSupportImpl.java >> to scan temporary directories to find out processes in the container. It >> checks inode to ensure the temp directory is not conflicted. Howev

Re: RFR: 8284330: jcmd may not be able to find processes in the container [v2]

2022-04-06 Thread Kevin Walls
On Wed, 6 Apr 2022 12:44:35 GMT, Yasumasa Suenaga wrote: >> jcmd uses >> src/jdk.internal.jvmstat/linux/classes/sun/jvmstat/PlatformSupportImpl.java >> to scan temporary directories to find out processes in the container. It >> checks inode to ensure the temp directory is not conflicted. Howev

Re: RFR: 8284330: jcmd may not be able to find processes in the container [v2]

2022-04-06 Thread Yasumasa Suenaga
> jcmd uses > src/jdk.internal.jvmstat/linux/classes/sun/jvmstat/PlatformSupportImpl.java > to scan temporary directories to find out processes in the container. It > checks inode to ensure the temp directory is not conflicted. However inode > maybe same value between the container and others.