Re: RFR: 8285364: Remove REF_ enum for java.lang.ref.Reference [v4]

2022-04-29 Thread Albert Mingkun Yang
On Fri, 29 Apr 2022 10:56:49 GMT, Kim Barrett wrote: >> The current approach limits the knowledge of non-strong ref types to >> `instanceRefKlass` file. > > The `_reference_type` used to be initialized correctly in most cases, but > needed fixing up for a few cases during bootstrapping. With thi

Re: RFR: 8285364: Remove REF_ enum for java.lang.ref.Reference [v4]

2022-04-29 Thread Kim Barrett
On Thu, 28 Apr 2022 20:06:47 GMT, Albert Mingkun Yang wrote: >> src/hotspot/share/oops/instanceKlass.cpp line 497: >> >>> 495: _nest_host_index(0), >>> 496: _init_state(allocated), >>> 497: _reference_type(REF_NONE), >> >> This is initializing `_reference_type` to the wrong value for a >

Re: RFR: 8285364: Remove REF_ enum for java.lang.ref.Reference [v4]

2022-04-28 Thread Albert Mingkun Yang
On Thu, 28 Apr 2022 11:05:45 GMT, Kim Barrett wrote: >> Albert Mingkun Yang has updated the pull request incrementally with two >> additional commits since the last revision: >> >> - comment >> - Rework reference type initialization >> >>Signed-off-by: Albert Yang > > src/hotspot/sha

Re: RFR: 8285364: Remove REF_ enum for java.lang.ref.Reference [v4]

2022-04-28 Thread Kim Barrett
On Thu, 28 Apr 2022 09:15:33 GMT, Albert Mingkun Yang wrote: >> Simple rename and some comments update. >> >> Test: build > > Albert Mingkun Yang has updated the pull request incrementally with two > additional commits since the last revision: > > - comment > - Rework reference type initiali

Re: RFR: 8285364: Remove REF_ enum for java.lang.ref.Reference [v4]

2022-04-28 Thread Albert Mingkun Yang
> Simple rename and some comments update. > > Test: build Albert Mingkun Yang has updated the pull request incrementally with two additional commits since the last revision: - comment - Rework reference type initialization Signed-off-by: Albert Yang - Changes: - all: h