On Wed, 11 May 2022 02:43:21 GMT, Ioi Lam wrote:
>> The `mode` parameter for ` jdk.internal.perf.Perf.attach()` has never
>> supported the value `"rw"` since the source code was imported to the openjdk
>> repo more than 15 years ago. In fact HotSpot throws
>> `IllegalArgumentException` when
On Tue, 10 May 2022 19:59:41 GMT, Alan Bateman wrote:
>> Ioi Lam has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> review comments
>
> src/jdk.internal.jvmstat/share/classes/sun/jvmstat/perfdata/monitor/protocol/file/PerfDataBuffer.java
>
On Tue, 10 May 2022 21:43:44 GMT, Claes Redestad wrote:
>> Ioi Lam has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> review comments
>
> src/hotspot/os/windows/perfMemory_windows.cpp line 1781:
>
>> 1779: // address space.
>> 1780: //
>>
> The `mode` parameter for ` jdk.internal.perf.Perf.attach()` has never
> supported the value `"rw"` since the source code was imported to the openjdk
> repo more than 15 years ago. In fact HotSpot throws
> `IllegalArgumentException` when such a mode is specified.
>
> It's unlikely such a mode