On Mon, 23 May 2022 19:33:31 GMT, Alan Bateman wrote:
>> This change is mostly test infrastructure and improvements to the testing of
>> thread dumps in JSON format. It also tweaks the thread dump format so that
>> the process identifier and thread identifiers are a type string rather than
>>
> This change is mostly test infrastructure and improvements to the testing of
> thread dumps in JSON format. It also tweaks the thread dump format so that
> the process identifier and thread identifiers are a type string rather than
> number.
>
> The tests for thread dumps added by JEP 425 are
On Mon, 23 May 2022 07:52:58 GMT, Alan Bateman wrote:
>> test/jdk/com/sun/management/HotSpotDiagnosticMXBean/DumpThreads.java line
>> 115:
>>
>>> 113:
>>> 114: // find the thread container that corresponds to the
>>> executor
>>> 115: String name = Objects.toId
On Mon, 23 May 2022 16:44:12 GMT, Chris Plummer wrote:
>> Alan Bateman has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Use string rater than number for process/thread identifiers
>
> test/lib/jdk/test/lib/threaddump/ThreadDump.java line
On Mon, 23 May 2022 07:53:09 GMT, Alan Bateman wrote:
>> test/lib/jdk/test/lib/threaddump/ThreadDump.java line 179:
>>
>>> 177: return this;
>>> 178: if (name().startsWith(name + "/"))
>>> 179: return this;
>>
>> It's not clear to me why this is here.
On Mon, 23 May 2022 08:30:51 GMT, Alan Bateman wrote:
>> This change is mostly test infrastructure and improvements to the testing of
>> thread dumps in JSON format. It also tweaks the thread dump format so that
>> the process identifier and thread identifiers are a type string rather than
>>
On Mon, 23 May 2022 08:30:51 GMT, Alan Bateman wrote:
>> This change is mostly test infrastructure and improvements to the testing of
>> thread dumps in JSON format. It also tweaks the thread dump format so that
>> the process identifier and thread identifiers are a type string rather than
>>
> This change is mostly test infrastructure and improvements to the testing of
> thread dumps in JSON format. It also tweaks the thread dump format so that
> the process identifier and thread identifiers are a type string rather than
> number.
>
> The tests for thread dumps added by JEP 425 are
On Mon, 23 May 2022 06:09:58 GMT, Chris Plummer wrote:
>> Alan Bateman has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Remove spurious colon
>
> test/jdk/com/sun/management/HotSpotDiagnosticMXBean/DumpThreads.java line 115:
>
>> 113:
>
On Fri, 20 May 2022 16:41:36 GMT, Alan Bateman wrote:
>> This is a test-only change to add some test infrastructure and improve the
>> testing of thread dumps in JSON format. The new tests added by JEP 425 for
>> this thread dump format search the JSON text for strings but don't parse it
>> co
> This is a test-only change to add some test infrastructure and improve the
> testing of thread dumps in JSON format. The new tests added by JEP 425 for
> this thread dump format search the JSON text for strings but don't parse it
> completely. These tests can be improved with a test class tha
On Fri, 20 May 2022 11:32:14 GMT, Alan Bateman wrote:
>> This is a test-only change to add some test infrastructure and improve the
>> testing of thread dumps in JSON format. The new tests added by JEP 425 for
>> this thread dump format search the JSON text for strings but don't parse it
>> co
On Fri, 20 May 2022 04:22:21 GMT, Chris Plummer wrote:
> I think a short example dump would actually be easier to read alongside the
> code.
That's a good idea. I've updated the class description to include an example
and also a code example of how it can be used in tests. The thread dump exam
> This is a test-only change to add some test infrastructure and improve the
> testing of thread dumps in JSON format. The new tests added by JEP 425 for
> this thread dump format search the JSON text for strings but don't parse it
> completely. These tests can be improved with a test class tha
On Thu, 19 May 2022 09:38:06 GMT, Alan Bateman wrote:
> This is a test-only change to add some test infrastructure and improve the
> testing of thread dumps in JSON format. The new tests added by JEP 425 for
> this thread dump format search the JSON text for strings but don't parse it
> comple
On Thu, 19 May 2022 09:38:06 GMT, Alan Bateman wrote:
> This is a test-only change to add some test infrastructure and improve the
> testing of thread dumps in JSON format. The new tests added by JEP 425 for
> this thread dump format search the JSON text for strings but don't parse it
> comple
On Thu, 19 May 2022 09:38:06 GMT, Alan Bateman wrote:
> This is a test-only change to add some test infrastructure and improve the
> testing of thread dumps in JSON format. The new tests added by JEP 425 for
> this thread dump format search the JSON text for strings but don't parse it
> comple
On Thu, 19 May 2022 15:28:01 GMT, Chris Plummer wrote:
> It would be useful if ThreadDump.java contained a comment with a description
> of the JSON file syntax. It could either be in the form of a simple dump or
> as a simple syntactic description.
Still TBD on where the JSON "schema" will be
On Thu, 19 May 2022 09:38:06 GMT, Alan Bateman wrote:
> This is a test-only change to add some test infrastructure and improve the
> testing of thread dumps in JSON format. The new tests added by JEP 425 for
> this thread dump format search the JSON text for strings but don't parse it
> comple
This is a test-only change to add some test infrastructure and improve the
testing of thread dumps in JSON format. The new tests added by JEP 425 for this
thread dump format search the JSON text for strings but don't parse it
completely. These tests can be improved with a test class that parses
20 matches
Mail list logo
