Re: RFR: JDK-8014048 - Online user guide of jconsole points incorrect link

2013-05-17 Thread Mandy Chung
On 5/17/2013 7:04 AM, Nils Loodin wrote: Updated webrev: http://cr.openjdk.java.net/~nloodin/8014048/webrev.03/src/ Looks good. Mandy

Re: RFR: JDK-8014048 - Online user guide of jconsole points incorrect link

2013-05-17 Thread Nils Loodin
Updated webrev: http://cr.openjdk.java.net/~nloodin/8014048/webrev.03/src/ On 05/15/2013 01:26 AM, Mandy Chung wrote: On 5/14/13 4:20 AM, Nils Loodin wrote: Mandy: Is the current relased saved somewhere accessible in the jdk It's stored in "java.version" property but it requires parsing to e

Re: RFR: JDK-8014048 - Online user guide of jconsole points incorrect link

2013-05-14 Thread Mandy Chung
On 5/14/13 4:20 AM, Nils Loodin wrote: Mandy: Is the current relased saved somewhere accessible in the jdk It's stored in "java.version" property but it requires parsing to extract the major release number. The private API sun.misc.Version.getMajorVersion returns that. or is that something

Re: RFR: JDK-8014048 - Online user guide of jconsole points incorrect link

2013-05-14 Thread Staffan Larsen
Looks good! /Staffan On 14 maj 2013, at 13:20, Nils Loodin wrote: > On 05/14/2013 01:28 AM, Mandy Chung wrote: >> On 5/13/13 1:50 PM, Staffan Larsen wrote: >>> Shouldn't the link be to the oracle site that the sun site redirects to: >>> >>> http://docs.oracle.com/javase/7/docs/technotes/guides

Re: RFR: JDK-8014048 - Online user guide of jconsole points incorrect link

2013-05-14 Thread Nils Loodin
On 05/14/2013 01:28 AM, Mandy Chung wrote: On 5/13/13 1:50 PM, Staffan Larsen wrote: Shouldn't the link be to the oracle site that the sun site redirects to: http://docs.oracle.com/javase/7/docs/technotes/guides/management/jconsole.html Staffan, yes, changed this. Can you take it further

Re: RFR: JDK-8014048 - Online user guide of jconsole points incorrect link

2013-05-13 Thread David Holmes
On 14/05/2013 6:50 AM, Staffan Larsen wrote: Shouldn't the link be to the oracle site that the sun site redirects to: http://docs.oracle.com/javase/7/docs/technotes/guides/management/jconsole.html My thoughts exactly. :) Also a pity the URL has to be repeated so often, but that's not caused

Re: RFR: JDK-8014048 - Online user guide of jconsole points incorrect link

2013-05-13 Thread Mandy Chung
On 5/13/13 1:50 PM, Staffan Larsen wrote: Shouldn't the link be to the oracle site that the sun site redirects to: http://docs.oracle.com/javase/7/docs/technotes/guides/management/jconsole.html Can you take it further to construct the link with the release version of the JRE: http://docs.ora

Re: RFR: JDK-8014048 - Online user guide of jconsole points incorrect link

2013-05-13 Thread Staffan Larsen
Shouldn't the link be to the oracle site that the sun site redirects to: http://docs.oracle.com/javase/7/docs/technotes/guides/management/jconsole.html /Staffan On 13 maj 2013, at 15:36, Nils Loodin wrote: > On 05/13/2013 03:36 PM, Nils Loodin wrote: >> Simple change of link in resource files:

Re: RFR: JDK-8014048 - Online user guide of jconsole points incorrect link

2013-05-13 Thread Jaroslav Bachorik
Fine with me (-not a reviewer-) -JB- On 05/13/2013 03:36 PM, Nils Loodin wrote: > On 05/13/2013 03:36 PM, Nils Loodin wrote: >> Simple change of link in resource files: >> >> https://jbs.oracle.com/bugs/browse/JDK-8014048 >> >> Regards, >> Nils Loodin > > > Also, with webrev link (might come in

Re: RFR: JDK-8014048 - Online user guide of jconsole points incorrect link

2013-05-13 Thread serguei.spit...@oracle.com
It looks good. Thank you for doing this! Should the bug's "Affects Version's" field also include 6u45? Thanks, Serguei On 5/13/13 6:36 AM, Nils Loodin wrote: On 05/13/2013 03:36 PM, Nils Loodin wrote: Simple change of link in resource files: https://jbs.oracle.com/bugs/browse/JDK-8014048 Re

Re: RFR: JDK-8014048 - Online user guide of jconsole points incorrect link

2013-05-13 Thread Peter Allwin
Looks good! /peter Nils LoodinMonday, May 13, 2013 3:36 PM Also, with webrev link (might come in handy): http://cr.openjdk.java.net/~nloodin/8014048/webrev.00/ Nils LoodinMonday, May 13, 2013 3:36 PM Simple change of link in resource files: https://jbs.oracle.com/bugs/brow

Re: RFR: JDK-8014048 - Online user guide of jconsole points incorrect link

2013-05-13 Thread Nils Loodin
On 05/13/2013 03:36 PM, Nils Loodin wrote: Simple change of link in resource files: https://jbs.oracle.com/bugs/browse/JDK-8014048 Regards, Nils Loodin Also, with webrev link (might come in handy): http://cr.openjdk.java.net/~nloodin/8014048/webrev.00/

RFR: JDK-8014048 - Online user guide of jconsole points incorrect link

2013-05-13 Thread Nils Loodin
Simple change of link in resource files: https://jbs.oracle.com/bugs/browse/JDK-8014048 Regards, Nils Loodin