oracle.com
Sent: Tuesday, March 24, 2015 3:57:54 PM GMT +04:00 Abu Dhabi / Muscat
Subject: Re: RFR: JDK-8075586: add @modules as needed to the open
hotspot tests
This looks good, thank you for making these changes! A couple of
comments that I don't feel need another webrev but should
penjdk.java.net, alexandre.il...@oracle.com
Sent: Friday, March 20, 2015 7:39:10 PM GMT +04:00 Abu Dhabi / Muscat
Subject: Re: RFR: JDK-8075586: add @modules as needed to the open
hotspot tests
I haven’t looked at the changes in detail, but please change the
requiredVersion in TEST.ROOT to 4.1 b11
PM GMT +04:00 Abu Dhabi / Muscat
Subject: Re: RFR: JDK-8075586: add @modules as needed to the open hotspot tests
This looks good, thank you for making these changes! A couple of
comments that I don't feel need another webrev but should be fixed
before pushing.
- copyrights on all the
h...@oracle.com,
alexandre.il...@oracle.com
Sent: Tuesday, March 24, 2015 3:57:54 PM GMT +04:00 Abu Dhabi / Muscat
Subject: Re: RFR: JDK-8075586: add @modules as needed to the open hotspot tests
This looks good, thank you for making these changes! A couple of
comments that I don't feel need anoth
gt;
>> Best regards,
>> Alex
>>
>> - Original Message -
>> From: staffan.lar...@oracle.com
>> To: alexander.kulyakh...@oracle.com
>> Cc: serviceability-dev@openjdk.java.net, alexandre.il...@oracle.com
>> Sent: Friday, March 20, 2015 7:39:10 PM
.@oracle.com
To: alexander.kulyakh...@oracle.com, lois.fol...@oracle.com
Cc: hotspot-...@openjdk.java.net, serviceability-dev@openjdk.java.net,
alexandre.il...@oracle.com
Sent: Tuesday, March 24, 2015 6:07:27 PM GMT +04:00 Abu Dhabi / Muscat
Subject: RE: RFR: JDK-8075586: add @modules as needed to the open ho
e.com
Sent: Tuesday, March 24, 2015 3:57:54 PM GMT +04:00 Abu Dhabi / Muscat
Subject: Re: RFR: JDK-8075586: add @modules as needed to the open hotspot tests
This looks good, thank you for making these changes! A couple of comments that
I don't feel need another webrev but should be fixed
015 3:57:54 PM GMT +04:00 Abu Dhabi / Muscat
Subject: Re: RFR: JDK-8075586: add @modules as needed to the open hotspot tests
This looks good, thank you for making these changes! A couple of
comments that I don't feel need another webrev but should be fixed
before pushing.
- copyrights
t, alexandre.il...@oracle.com
Sent: Friday, March 20, 2015 7:39:10 PM GMT +04:00 Abu Dhabi / Muscat
Subject: Re: RFR: JDK-8075586: add @modules as needed to the open
hotspot tests
I haven’t looked at the changes in detail, but please change the
requiredVersion in TEST.ROOT to 4.1 b11 as part
:10 PM GMT +04:00 Abu Dhabi / Muscat
Subject: Re: RFR: JDK-8075586: add @modules as needed to the open hotspot tests
I haven’t looked at the changes in detail, but please change the
requiredVersion in TEST.ROOT to 4.1 b11 as part of this change.
Thanks,
/Staffan
On 20 mar 2015, at 13:16
,
Alex
- Original Message -
From: staffan.lar...@oracle.com
To: alexander.kulyakh...@oracle.com
Cc: serviceability-dev@openjdk.java.net, alexandre.il...@oracle.com
Sent: Friday, March 20, 2015 7:39:10 PM GMT +04:00 Abu Dhabi / Muscat
Subject: Re: RFR: JDK-8075586: add @modules as needed to the
I haven’t looked at the changes in detail, but please change the
requiredVersion in TEST.ROOT to 4.1 b11 as part of this change.
Thanks,
/Staffan
> On 20 mar 2015, at 13:16, Alexander Kulyakhtin
> wrote:
>
> Hi,
>
> Could you, please, review the fix below.
>
> CR: https://bugs.openjdk.java.
Hi,
Could you, please, review the fix below.
CR: https://bugs.openjdk.java.net/browse/JDK-8075586
webrev: http://cr.openjdk.java.net/~tpivovarova/akulyakh/8075586/webrev.00/
The fix adds @modules keyword to the existing hotspot tests, as needed, so that
the tests can access the required API whe
13 matches
Mail list logo
