Re: RFR: JDK-8142336: Convert the SA agent build to modular build-infra makefiles

2015-11-11 Thread Dmitry Samersoff
Erik, Could you please file a new CR for warnings and assign it to me? -Dmitry On 2015-11-11 12:31, Erik Joelsson wrote: > New webrev: http://cr.openjdk.java.net/~erikj/8142336/webrev.02/ > > Fixed the issues listed below. Reverted the faulty attempt at fixing a > warning. Did a more thorough a

Re: RFR: JDK-8142336: Convert the SA agent build to modular build-infra makefiles

2015-11-11 Thread Magnus Ihse Bursie
On 2015-11-11 10:31, Erik Joelsson wrote: New webrev: http://cr.openjdk.java.net/~erikj/8142336/webrev.02/ Fixed the issues listed below. Reverted the faulty attempt at fixing a warning. Did a more thorough attempt at clearing out all references to SA in the old makefiles. Looks great. There

Re: RFR: JDK-8142336: Convert the SA agent build to modular build-infra makefiles

2015-11-11 Thread Erik Joelsson
New webrev: http://cr.openjdk.java.net/~erikj/8142336/webrev.02/ Fixed the issues listed below. Reverted the faulty attempt at fixing a warning. Did a more thorough attempt at clearing out all references to SA in the old makefiles. /Erik On 2015-11-10 14:49, Magnus Ihse Bursie wrote: On 201

Re: RFR: JDK-8142336: Convert the SA agent build to modular build-infra makefiles

2015-11-10 Thread Magnus Ihse Bursie
On 2015-11-10 11:39, Magnus Ihse Bursie wrote: On 2015-11-09 19:33, Erik Joelsson wrote: Hello, As a stepping stone in the hotspot makefile conversion, I have broken out the serviceability agent separately and converted it into proper modular build-infra makefiles. Doing this conversion separ

Re: RFR: JDK-8142336: Convert the SA agent build to modular build-infra makefiles

2015-11-10 Thread Magnus Ihse Bursie
On 2015-11-09 19:33, Erik Joelsson wrote: Hello, As a stepping stone in the hotspot makefile conversion, I have broken out the serviceability agent separately and converted it into proper modular build-infra makefiles. Doing this conversion separately has some value on its own by reducing the

RFR: JDK-8142336: Convert the SA agent build to modular build-infra makefiles

2015-11-09 Thread Erik Joelsson
Hello, As a stepping stone in the hotspot makefile conversion, I have broken out the serviceability agent separately and converted it into proper modular build-infra makefiles. Doing this conversion separately has some value on its own by reducing the special cases currently needed for buildi