There is an old reported problem that using jmap on a process that is
not running
Java could cause the process to terminate. This is due to the SIGQUIT used
when attaching to the process.
It is a fairly simple operation to validate that the pid matches one of
the known
running Java processes u
Hi Gary,
What about the other tools that attach to a user specified process. Do
they also have this issue?
thanks,
Chris
On 2/14/19 8:35 AM, Gary Adams wrote:
There is an old reported problem that using jmap on a process that is
not running
Java could cause the process to terminate. This is
The following commands present a similar kill process behavior:
jcmd
jinfo
jmap
jstack
The following commands do not attach.
jstat sun.jvmstat.monitor.MonitorException "not found"
jps no pid arguments
This update moves the checkJavaPid method into the
common/ProcessArgumentsMa
Hi Gary,
thanks for taking this on. I have occasionally killed a foreign process
with jcmd and it is a bit embarrassing :)
I think your patch is okay, but I wonder whether a check directly in
libattach would be simpler and cover all uses of the attach framework.
Such a test could be e.g. simply
Looks good to me. You could also take on Thomas' suggestion, but I'm not
sure if there are any common use cases that it would be protecting us
from accidentally killing a process (other than the ones you are already
fixing).
Chris
On 2/14/19 11:12 AM, Gary Adams wrote:
The following commands
Gary,
What is the overhead of doing the validation? How do we list VMs? Do we
need to examine every running process to get the list of VMs? Wouldn't
it be better to check the given process is a VM rather than checking all
potential VM processes?
I think there is an onus of responsibility on
On Fri, Feb 15, 2019 at 3:26 AM David Holmes
wrote:
> Gary,
>
> What is the overhead of doing the validation? How do we list VMs? Do we
> need to examine every running process to get the list of VMs? Wouldn't
> it be better to check the given process is a VM rather than checking all
> potential V
Let me clarify a few things about the proposed fix.
The VirtualMachine.list() mechanism is based on
Java processes that are up and running.
During VM startup when agent libraries are loaded,
the fact is recorded in the filesystem that a Java process
is eligible for an attach request.
This is a m
im
Auftrag von gary.ad...@oracle.com
Gesendet: Freitag, Februar 15, 2019 12:07 PM
An: Thomas Stüfe; David Holmes; Chris Plummer
Cc: OpenJDK Serviceability
Betreff: Re: RFR: JDK-8149461: jmap kills process if non-java pid is specified
in the command line
Let me clarify a few things about the
/bernd.eckenfels.net
*Von:* serviceability-dev
im Auftrag von
gary.ad...@oracle.com
*Gesendet:* Freitag, Februar 15, 2019 12:07 PM
*An:* Thomas Stüfe; David Holmes; Chris Plummer
*Cc:* OpenJDK Serviceability
*Betreff:* Re: RFR: JDK-8149461: jmap kills process if non-java pid is
spec
On 15/02/2019 8:04 pm, gary.ad...@oracle.com wrote:
Let me clarify a few things about the proposed fix.
The VirtualMachine.list() mechanism is based on
Java processes that are up and running.
During VM startup when agent libraries are loaded,
the fact is recorded in the filesystem that a Java pr
enJDK Serviceability
*Betreff:* Re: RFR: JDK-8149461: jmap kills process if non-java pid
is specified in the command line
Let me clarify a few things about the proposed fix.
The VirtualMachine.list() mechanism is based on
Java processes that are up and running.
During VM startup when agent libraries
On 2/15/19, 8:18 AM, David Holmes wrote:
On 15/02/2019 8:04 pm, gary.ad...@oracle.com wrote:
Let me clarify a few things about the proposed fix.
The VirtualMachine.list() mechanism is based on
Java processes that are up and running.
During VM startup when agent libraries are loaded,
the fact is
: Freitag, Februar 15, 2019 2:19 PM
An: gary.ad...@oracle.com
Cc: Bernd Eckenfels; OpenJDK Serviceability
Betreff: Re: RFR: JDK-8149461: jmap kills process if non-java pid is specified
in the command line
On a linux system with 1 Java process and 500 non-Java processes,
/tmp is not tmpfs mounted, 20 runs
On 15/02/2019 11:28 pm, Gary Adams wrote:
On 2/15/19, 8:18 AM, David Holmes wrote:
On 15/02/2019 8:04 pm, gary.ad...@oracle.com wrote:
Let me clarify a few things about the proposed fix.
The VirtualMachine.list() mechanism is based on
Java processes that are up and running.
During VM startup w
enfels.net
*Von:* Gary Adams
*Gesendet:* Freitag, Februar 15, 2019 2:19 PM
*An:* gary.ad...@oracle.com
*Cc:* Bernd Eckenfels; OpenJDK Serviceability
*Betreff:* Re: RFR: JDK-8149461: jmap kills process if non-java pid is
specified in the command line
On a linux system with 1 Java process and 50
; function). It’s not the best Situation if your diagnostic attempts are slow
>> down in such a situation.
>>
>> Also in the past not all VMs might be recognized by the list function, a
>> more targeted attach could still succeed. Is that addressed since the
>> container-PID cha
esendet:* Freitag, Februar 15, 2019 2:19 PM
> *An:* gary.ad...@oracle.com
> *Cc:* Bernd Eckenfels; OpenJDK Serviceability
> *Betreff:* Re: RFR: JDK-8149461: jmap kills process if non-java pid is
> specified in the command line
>
> On a linux system with 1 Java process and 500 non-J
Freitag, Februar 15, 2019 2:19 PM
*An:* gary.ad...@oracle.com
*Cc:* Bernd Eckenfels; OpenJDK Serviceability
*Betreff:* Re: RFR: JDK-8149461: jmap kills process if non-java pid
is specified in the command line
On a linux system with 1 Java process and 500 non-Java processes,
/tmp is not tmpfs mou
-dev
im Auftrag von
gary.ad...@oracle.com
*Gesendet:* Freitag, Februar 15, 2019 12:07 PM
*An:* Thomas Stüfe; David Holmes; Chris Plummer
*Cc:* OpenJDK Serviceability
*Betreff:* Re: RFR: JDK-8149461: jmap kills process if non-java
pid is specified in the command line
Let me clarify a few things about
d
Gruss
Bernd
--
http://bernd.eckenfels.net
*Von:* Gary Adams
*Gesendet:* Freitag, Februar 15, 2019 2:19 PM
*An:* gary.ad...@oracle.com
*Cc:* Bernd Eckenfels; OpenJDK Serviceability
*Betreff:* Re: RFR: JDK-8149461: jmap kills p
--
*Von:* Gary Adams
*Gesendet:* Freitag, Februar 15, 2019 2:19 PM
*An:* gary.ad...@oracle.com
*Cc:* Bernd Eckenfels; OpenJDK Serviceability
*Betreff:* Re: RFR: JDK-8149461: jmap kills process if non-java
pid is specified in the command line
On a linux system with 1 Java
Von: Gary Adams
Gesendet: Freitag, Februar 15, 2019 2:19 PM
An: gary.ad...@oracle.com
Cc: Bernd Eckenfels; OpenJDK Serviceability
Betreff: Re: RFR: JDK-8149461: jmap kills
process if
p://bernd.eckenfels.net
------------
*Von:* Gary Adams
*Gesendet:* Freitag, Februar 15, 2019 2:19 PM
*An:* gary.ad...@oracle.com
*Cc:* Bernd Eckenfels; OpenJDK Serviceability
*Betreff:* Re: RFR: JDK-8149461: jmap kills process if non-jav
ttp://bernd.eckenfels.net
------------
*Von:* Gary Adams
*Gesendet:* Freitag, Februar 15, 2019 2:19 PM
*An:* gary.ad...@oracle.com
*Cc:* Bernd Eckenfels; OpenJDK Serviceability
*Betreff:* Re: RFR: JDK-8149461: jmap kills process if non-jav
--
*Von:* serviceability-dev
im Auftrag von
gary.ad...@oracle.com
*Gesendet:* Freitag, Februar 15, 2019 12:07 PM
*An:* Thomas St�fe; David Holmes; Chris Plummer
*Cc:* OpenJDK Serviceability
*Betreff:* Re: RFR: JDK-8149461: jmap kills process if
non-java pid is specified
*Von:* serviceability-dev
im Auftrag von
gary.ad...@oracle.com
*Gesendet:* Freitag, Februar 15, 2019 12:07 PM
*An:* Thomas Stüfe; David Holmes; Chris Plummer
*Cc:* OpenJDK Serviceability
*Betreff:* Re: RFR: JDK-8149461: jmap kills pro
-
*Von:* serviceability-dev
im Auftrag von
gary.ad...@oracle.com
*Gesendet:* Freitag, Februar 15, 2019 12:07 PM
*An:* Thomas Stüfe; David Holmes; Chris Plummer
*Cc:* OpenJDK Serviceability
*Betreff:* Re: RFR: JDK-8149461: jmap kills process if
non-java pid is specified in the
28 matches
Mail list logo