Hi all,
HSDB toolbar icons
(hotspot/src/jdk.hotspot.agent/share/classes/images/toolbarButtonGraphics)
are missing in appmodules.jimage .
They should be contained to appmodules.jimage .
I've uploaded a webrev:
http://cr.openjdk.java.net/~ysuenaga/JDK-8150723/webrev.00/
Could you review it?
Hi Erik,
Thanks!
I've uploaded new webrev. Could you review it?
http://cr.openjdk.java.net/~ysuenaga/JDK-8150723/webrev.01/
> However, the real fix is to move the gifs out of the images dir so that
> they have the correct subdir relative to the classes dir in both the
> source and the output. T
On 2016-02-27 04:44, Yasumasa Suenaga wrote:
> Hi Erik,
>
> Thanks!
> I've uploaded new webrev. Could you review it?
> http://cr.openjdk.java.net/~ysuenaga/JDK-8150723/webrev.01/
This looks ok to me.
>> However, the real fix is to move the gifs out of the images dir so that
>> they have the cor
Yasumasa,
I think it's better to have a complete fix rather than yet another
workaround.
Could you move gif files to correct location and remove custom makefile
logic?
I'll sponsor the push then.
-Dmitry
On 2016-02-27 06:44, Yasumasa Suenaga wrote:
> Hi Erik,
>
> Thanks!
> I've uploaded new w
Hi Dmitry, Erik,
I've uploaded new webrev:
hotspot: http://cr.openjdk.java.net/~ysuenaga/JDK-8150723/webrev.02/hotspot/
makefile: http://cr.openjdk.java.net/~ysuenaga/JDK-8150723/webrev.02/make/
> Could you move gif files to correct location and remove custom makefile
> logic?
I moved cla
Yasumasa,
Looks good for me!
-Dmitry
On 2016-02-29 16:26, Yasumasa Suenaga wrote:
> Hi Dmitry, Erik,
>
> I've uploaded new webrev:
>
> hotspot:
> http://cr.openjdk.java.net/~ysuenaga/JDK-8150723/webrev.02/hotspot/
> makefile: http://cr.openjdk.java.net/~ysuenaga/JDK-8150723/webrev.02/ma
Looks correct to me. Thanks for doing this!
/Erik
On 2016-02-29 14:28, Dmitry Samersoff wrote:
> Yasumasa,
>
> Looks good for me!
>
> -Dmitry
>
>
> On 2016-02-29 16:26, Yasumasa Suenaga wrote:
>> Hi Dmitry, Erik,
>>
>> I've uploaded new webrev:
>>
>> hotspot:
>> http://cr.openjdk.java.net/~ys
