RFR: JDK-8164012: com/sun/jdi/CatchPatternTest.sh fails on jdk9/hs with Required output "Exception occurred: java.lang.IllegalMonitorStateException" not found

2016-08-15 Thread Staffan Larsen
All, Please review this fix for a test that starting failing after recent changes to java.lang.invoke. The test instructs jdb to break on all exceptions matching "java.lang.I*" (that's a capital 'i'). The semantics of that operation actually means "break on all exceptions which have a class n

Re: RFR: JDK-8164012: com/sun/jdi/CatchPatternTest.sh fails on jdk9/hs with Required output "Exception occurred: java.lang.IllegalMonitorStateException" not found

2016-08-15 Thread Dmitry Samersoff
Staffan, Looks good for me! -Dmitry On 2016-08-15 21:15, Staffan Larsen wrote: > All, > > Please review this fix for a test that starting failing after recent changes > to java.lang.invoke. > > The test instructs jdb to break on all exceptions matching "java.lang.I*" > (that's a capital 'i

Re: RFR: JDK-8164012: com/sun/jdi/CatchPatternTest.sh fails on jdk9/hs with Required output "Exception occurred: java.lang.IllegalMonitorStateException" not found

2016-08-15 Thread Staffan Larsen
Thank you! > On 15 aug. 2016, at 20:27, Dmitry Samersoff > wrote: > > Staffan, > > Looks good for me! > > -Dmitry > > > On 2016-08-15 21:15, Staffan Larsen wrote: >> All, >> >> Please review this fix for a test that starting failing after recent changes >> to java.lang.invoke. >> >> The

Re: RFR: JDK-8164012: com/sun/jdi/CatchPatternTest.sh fails on jdk9/hs with Required output "Exception occurred: java.lang.IllegalMonitorStateException" not found

2016-08-15 Thread David Holmes
Hi Staffan, Looks good. Though I do wonder how the matching logic works such that the superclass is considered. I suppose it is a "feature" to match on X and all subclasses of X, but probably should be a way to match on exactly X not subclasses. Anyway just idle thoughts. :) Thanks, David

Re: RFR: JDK-8164012: com/sun/jdi/CatchPatternTest.sh fails on jdk9/hs with Required output "Exception occurred: java.lang.IllegalMonitorStateException" not found

2016-08-16 Thread Staffan Larsen
Thanks David! The matching logic is not that complicated (but it took me the better part of a day to figure all of this out.) The debugger sets a filter for which exceptions should be reported. Part of that filter includes a class reference. If the exception class IsInstanceOf() the class in th