Re: RFR: JDK-8199682 Clean up building the saproc library

Hi, Sounds good - so long as we don't have scripts that depend on the old name. Or if those could be fixed... -Sundar On 20/03/18, 4:54 PM, Magnus Ihse Bursie wrote: On 2018-03-16 19:12, Magnus Ihse Bursie wrote: Hi Sundar, I almost missed your mail, since you removed both me and

Re: RFR: JDK-8199682 Clean up building the saproc library

On 2018-03-16 19:12, Magnus Ihse Bursie wrote: Hi Sundar, I almost missed your mail, since you removed both me and build-dev from the cc list... 16 mars 2018 kl. 06:14 skrev Sundararajan Athijegannathan : Renaming sawindbg as saproc sounds odd. For

Re: RFR: JDK-8199682 Clean up building the saproc library

Hi Sundar, I almost missed your mail, since you removed both me and build-dev from the cc list... > 16 mars 2018 kl. 06:14 skrev Sundararajan Athijegannathan > : > > Renaming sawindbg as saproc sounds odd. For Linux, Solaris/Unix, we either > use

Re: RFR: JDK-8199682 Clean up building the saproc library

On 16/03/2018 9:49 PM, Magnus Ihse Bursie wrote: On 2018-03-16 04:13, David Holmes wrote: Hi Magnus, Overall this seems okay. Thanks! On 16/03/2018 4:22 AM, Magnus Ihse Bursie wrote: The saproc library has historically been built in quite odd ways on almost all platforms. When the old

Re: RFR: JDK-8199682 Clean up building the saproc library

On 2018-03-16 04:13, David Holmes wrote: Hi Magnus, Overall this seems okay. Thanks! On 16/03/2018 4:22 AM, Magnus Ihse Bursie wrote: The saproc library has historically been built in quite odd ways on almost all platforms. When the old build system was converted, this was not changed.

Re: RFR: JDK-8199682 Clean up building the saproc library

Renaming sawindbg as saproc sounds odd. For Linux, Solaris/Unix, we either use /proc & libproc, so calling saproc for those makes sense. But Windows? We have a separate debugger class to load platform specific native library. What is the reason for uniform naming? -Sundar On 16/03/18, 12:19

Re: RFR: JDK-8199682 Clean up building the saproc library

Hi Magnus, Overall this seems okay. On 16/03/2018 4:22 AM, Magnus Ihse Bursie wrote: The saproc library has historically been built in quite odd ways on almost all platforms. When the old build system was converted, this was not changed. However, now the time has come to streamline this and

Re: RFR: JDK-8199682 Clean up building the saproc library

On 2018-03-15 19:39, Erik Joelsson wrote: Looks good to me. The removed source files, are those some kind of tests? I don't really know; they have been excluded from the build for all time. My guess is that the Bsd* stuff is, like in the case of the sound libraries, bsd-based stuff that

Re: RFR: JDK-8199682 Clean up building the saproc library

Looks good to me. The removed source files, are those some kind of tests? /Erik On 2018-03-15 11:22, Magnus Ihse Bursie wrote: The saproc library has historically been built in quite odd ways on almost all platforms. When the old build system was converted, this was not changed. However,