Re: RFR: JDK-8214756: SA should ignore archived java heap objects that are not in use

2019-02-24 Thread Jini George
Thanks a bunch, Claes! - Jini On 2/24/2019 5:25 PM, Claes Redestad wrote: Hi Jini, changes looks good, and thanks for verifying your fix unblock 8214712! /Claes On 2019-02-24 06:01, Jini George wrote: Thank you very much, Jiangli! Yes, I did test open/test/hotspot/jtreg/serviceability/sa/Te

Re: RFR: JDK-8214756: SA should ignore archived java heap objects that are not in use

2019-02-24 Thread Claes Redestad
Hi Jini, changes looks good, and thanks for verifying your fix unblock 8214712! /Claes On 2019-02-24 06:01, Jini George wrote: Thank you very much, Jiangli! Yes, I did test open/test/hotspot/jtreg/serviceability/sa/TestHeapDumpForLargeArray.java after applying the changes from: http://cr.op

Re: RFR: JDK-8214756: SA should ignore archived java heap objects that are not in use

2019-02-23 Thread Jini George
Thank you very much, Jiangli! Yes, I did test open/test/hotspot/jtreg/serviceability/sa/TestHeapDumpForLargeArray.java after applying the changes from: http://cr.openjdk.java.net/~redestad/8214712/jdk.00/ and it passed after this change. Thanks, Jini. On 2/24/2019 9:38 AM, Jiangli Zhou wrote

RFR: JDK-8214756: SA should ignore archived java heap objects that are not in use

2019-02-23 Thread Jini George
Requesting reviews for a very small change to fix: https://bugs.openjdk.java.net/browse/JDK-8214756 Webrev: http://cr.openjdk.java.net/~jgeorge/8214756/webrev.00/index.html The proposed change is to ignore objects whose associated classes are unloaded while walking the heap to create a heapdum