Re: RFR: JDK-8224028: loop initial declarations introduced by JDK-8184770 (jdwp)

Hi Ao Qi, I'm adding serviceability-dev, since this is for jdwp. The proposed changes look good to me - but please get someone from the serviceability team to review this. best regards, -- daniel On 16/05/2019 08:41, Ao Qi wrote: Hi, I found build is failed on CentOS 7.6, because of loop i

Re: RFR: JDK-8224028: loop initial declarations introduced by JDK-8184770 (jdwp)

Hi Ao Qi, It looks good to me. Thank you for taking care about it! One minor comment on the fragment: 474 if (mask != NULL) { 475 if (parseAllowedMask(mask, isIPv4, &(_peers[_peers_cnt].netmask)) != JDWPTRANSPORT_ERROR_NONE) {

Re: RFR: JDK-8224028: loop initial declarations introduced by JDK-8184770 (jdwp)

What compiler was used here? We shouldn't be using anything that doesn't handle loop variable declarations! Thanks, David On 16/05/2019 7:41 pm, Daniel Fuchs wrote: Hi Ao Qi, I'm adding serviceability-dev, since this is for jdwp. The proposed changes look good to me - but please get someone

Re: RFR: JDK-8224028: loop initial declarations introduced by JDK-8184770 (jdwp)

On 05/16/2019 06:41, Ao Qi wrote: Hi Serguei, I saw your email [1], but I didn't receive it yet. Thanks for your review! I updated: http://cr.openjdk.java.net/~aoqi/8224028/webrev.01/ Looks good. --alex On Thu, May 16, 2019 at 8:30 PM David Holmes wrote: What compiler was used here?

Re: RFR: JDK-8224028: loop initial declarations introduced by JDK-8184770 (jdwp)

Hi Ao Qi, Thank you for the update. It looks good to me. Do you need a sponsor for integration? Thanks, Serguei On 5/16/19 09:38, Alex Menkov wrote: On 05/16/2019 06:41, Ao Qi wrote: Hi Serguei, I saw your email [1], but I didn't receive it yet. Thanks for your review! I updated: http:/

Re: RFR: JDK-8224028: loop initial declarations introduced by JDK-8184770 (jdwp)

On Fri, May 17, 2019 at 12:44 AM serguei.spit...@oracle.com wrote: > > Hi Ao Qi, > > Thank you for the update. > It looks good to me. Thanks! > > Do you need a sponsor for integration? Yes:) > > Thanks, > Serguei > > > On 5/16/19 09:38, Alex Menkov wrote: > > > > > > On 05/16/2019 06:41, Ao Qi

Re: RFR: JDK-8224028: loop initial declarations introduced by JDK-8184770 (jdwp)

On 17/05/2019 12:26 am, Jean Christophe Beyler wrote: From my experience, some compiler in Solaris/Windows complain about this (or used to a year ago via the submit repo); Serguei and I had to do this dance when we were getting the heap monitoring tests in. An I think the tests are different

Re: RFR: JDK-8224028: loop initial declarations introduced by JDK-8184770 (jdwp)

On 16/05/2019 11:41 pm, Ao Qi wrote: Hi Serguei, I saw your email [1], but I didn't receive it yet. Thanks for your review! I updated: http://cr.openjdk.java.net/~aoqi/8224028/webrev.01/ On Thu, May 16, 2019 at 8:30 PM David Holmes wrote: What compiler was used here? We shouldn't be using a

Re: RFR: JDK-8224028: loop initial declarations introduced by JDK-8184770 (jdwp)

On 17/05/2019 8:57 am, Martin Buchholz wrote: Maybe you just need to ask gcc to use a more modern -std=... It might reasonably be defaulting to gnu89 https://stackoverflow.com/questions/14737104/what-is-the-default-c-mode-for-the-current-gcc-especially-on-ubuntu Yes, but I thought we'd already

Re: RFR: JDK-8224028: loop initial declarations introduced by JDK-8184770 (jdwp)

Maybe you just need to ask gcc to use a more modern -std=... It might reasonably be defaulting to gnu89 https://stackoverflow.com/questions/14737104/what-is-the-default-c-mode-for-the-current-gcc-especially-on-ubuntu On Thu, May 16, 2019 at 3:25 PM David Holmes wrote: > On 16/05/2019 11:41 pm, A

Re: RFR: JDK-8224028: loop initial declarations introduced by JDK-8184770 (jdwp)

On Thu, May 16, 2019 at 4:05 PM David Holmes wrote: > On 17/05/2019 8:57 am, Martin Buchholz wrote: > > Maybe you just need to ask gcc to use a more modern -std=... > > It might reasonably be defaulting to gnu89 > > > https://stackoverflow.com/questions/14737104/what-is-the-default-c-mode-for-the

Re: RFR: JDK-8224028: loop initial declarations introduced by JDK-8184770 (jdwp)

On 17/05/2019 9:14 am, Martin Buchholz wrote: On Thu, May 16, 2019 at 4:05 PM David Holmes > wrote: On 17/05/2019 8:57 am, Martin Buchholz wrote: > Maybe you just need to ask gcc to use a more modern -std=... > It might reasonably be defaulting to gn

Re: RFR: JDK-8224028: loop initial declarations introduced by JDK-8184770 (jdwp)

Hi, Aleksey has helped to push: http://hg.openjdk.java.net/jdk/jdk/rev/3205f4c40716. Thank you all! Cheers, Ao Qi On Fri, May 17, 2019 at 8:19 AM David Holmes wrote: > > On 17/05/2019 9:14 am, Martin Buchholz wrote: > > On Thu, May 16, 2019 at 4:05 PM David Holmes >