RE: RFR: JDK-8224642: Test sun/tools/jcmd/TestJcmdSanity.java fails: Bad file descriptor

2019-06-20 Thread Langer, Christoph
Serviceability ; > Schmelter, Ralf > Subject: Re: RFR: JDK-8224642: Test sun/tools/jcmd/TestJcmdSanity.java > fails: Bad file descriptor > > During testing the failure was only observed in a questionable > test on linux-x64-debug builds. I question whether P3 was a > correct assessm

Re: RFR: JDK-8224642: Test sun/tools/jcmd/TestJcmdSanity.java fails: Bad file descriptor

2019-06-20 Thread gary.ad...@oracle.com
c: OpenJDK Serviceability ; Schmelter, Ralf Subject: Re: RFR: JDK-8224642: Test sun/tools/jcmd/TestJcmdSanity.java fails: Bad file descriptor That would be consistent with the windows detach() synchronization. Updated patch is attached. On 6/19/19, 8:14 AM, Langer, Christoph wrote: Hi Gary, looks good

RE: RFR: JDK-8224642: Test sun/tools/jcmd/TestJcmdSanity.java fails: Bad file descriptor

2019-06-19 Thread Langer, Christoph
woch, 19. Juni 2019 16:32 > To: Langer, Christoph > Cc: OpenJDK Serviceability ; > Schmelter, Ralf > Subject: Re: RFR: JDK-8224642: Test sun/tools/jcmd/TestJcmdSanity.java > fails: Bad file descriptor > > That would be consistent with the windows detach() synchronization. >

Re: RFR: JDK-8224642: Test sun/tools/jcmd/TestJcmdSanity.java fails: Bad file descriptor

2019-06-19 Thread Chris Plummer
a bug to track fixing of the InputStream implementation... Best regards Christoph -Original Message- From: serviceability-dev On Behalf Of gary.ad...@oracle.com Sent: Dienstag, 18. Juni 2019 12:08 To: OpenJDK Serviceability Subject: RFR: JDK-8224642: Test sun/tools/jcmd/TestJc

Re: RFR: JDK-8224642: Test sun/tools/jcmd/TestJcmdSanity.java fails: Bad file descriptor

2019-06-19 Thread Gary Adams
pt to close the stream. Cheers Christoph -Original Message- From: Gary Adams Sent: Mittwoch, 19. Juni 2019 13:59 To: Langer, Christoph Cc: OpenJDK Serviceability; Schmelter, Ralf Subject: Re: RFR: JDK-8224642: Test sun/tools/jcmd/TestJcmdSanity.java fails: Bad file descriptor I think everyo

Re: RFR: JDK-8224642: Test sun/tools/jcmd/TestJcmdSanity.java fails: Bad file descriptor

2019-06-19 Thread Chris Plummer
ph Cc: OpenJDK Serviceability; Schmelter, Ralf Subject: Re: RFR: JDK-8224642: Test sun/tools/jcmd/TestJcmdSanity.java fails: Bad file descriptor I think everyone is in agreement now that preventing the double close is the best way to handle this failure. If there are no further comments, I'l

Re: RFR: JDK-8224642: Test sun/tools/jcmd/TestJcmdSanity.java fails: Bad file descriptor

2019-06-19 Thread Gary Adams
. Cheers Christoph -Original Message- From: Gary Adams Sent: Mittwoch, 19. Juni 2019 13:59 To: Langer, Christoph Cc: OpenJDK Serviceability; Schmelter, Ralf Subject: Re: RFR: JDK-8224642: Test sun/tools/jcmd/TestJcmdSanity.java fails: Bad file descriptor I think everyone is in agreement now

RE: RFR: JDK-8224642: Test sun/tools/jcmd/TestJcmdSanity.java fails: Bad file descriptor

2019-06-19 Thread Langer, Christoph
gt; Cc: OpenJDK Serviceability ; > Schmelter, Ralf > Subject: Re: RFR: JDK-8224642: Test sun/tools/jcmd/TestJcmdSanity.java > fails: Bad file descriptor > > I think everyone is in agreement now that preventing the double close > is the best way to handle this failure. If there are

Re: RFR: JDK-8224642: Test sun/tools/jcmd/TestJcmdSanity.java fails: Bad file descriptor

2019-06-19 Thread Gary Adams
nputStream implementation... Best regards Christoph -Original Message- From: serviceability-dev On Behalf Of gary.ad...@oracle.com Sent: Dienstag, 18. Juni 2019 12:08 To: OpenJDK Serviceability Subject: RFR: JDK-8224642: Test sun/tools/jcmd/TestJcmdSanity.java fails: Bad file descrip

RE: RFR: JDK-8224642: Test sun/tools/jcmd/TestJcmdSanity.java fails: Bad file descriptor

2019-06-18 Thread Langer, Christoph
implementation... Best regards Christoph > -Original Message- > From: serviceability-dev On > Behalf Of gary.ad...@oracle.com > Sent: Dienstag, 18. Juni 2019 12:08 > To: OpenJDK Serviceability > Subject: RFR: JDK-8224642: Test sun/tools/jcmd/TestJcmdSanity.java fails: > Bad

RFR: JDK-8224642: Test sun/tools/jcmd/TestJcmdSanity.java fails: Bad file descriptor

2019-06-18 Thread gary.ad...@oracle.com
The workaround below passed 1000 testruns on linux-x64-debug. A more localized fix simply moves the stream reader out of the try with resources, so only one close is applied to the underlying socket. I'll run this test through 1000 testruns today. Looking for a final review for this change. dif