On 1/23/20 3:12 PM, Alex Menkov wrote:
On 01/23/2020 13:56, Chris Plummer wrote:
On 1/23/20 1:16 PM, Alex Menkov wrote:
On 01/23/2020 12:35, Chris Plummer wrote:
On 1/23/20 11:21 AM, Alex Menkov wrote:
...skipped...
I don't care much about this change and can revert it.
OK.
What does
On 01/23/2020 13:56, Chris Plummer wrote:
On 1/23/20 1:16 PM, Alex Menkov wrote:
On 01/23/2020 12:35, Chris Plummer wrote:
On 1/23/20 11:21 AM, Alex Menkov wrote:
...skipped...
I don't care much about this change and can revert it.
OK.
What does the "OK" mean? :)
Do you prefer revert
On 1/23/20 1:16 PM, Alex Menkov wrote:
On 01/23/2020 12:35, Chris Plummer wrote:
On 1/23/20 11:21 AM, Alex Menkov wrote:
...skipped...
Why is the following not placed at the end if the "if" block:
299 AddRef();
300 return S_OK;
The following was removed. It's not clear to me wh
On 01/23/2020 12:35, Chris Plummer wrote:
On 1/23/20 11:21 AM, Alex Menkov wrote:
...skipped...
Why is the following not placed at the end if the "if" block:
299 AddRef();
300 return S_OK;
The following was removed. It's not clear to me why it was and what
the impact is:
2
On 1/23/20 11:21 AM, Alex Menkov wrote:
Hi Chris,
On 01/22/2020 19:21, Chris Plummer wrote:
On 1/22/20 12:23 PM, Alex Menkov wrote:
Hi Chris,
On 01/17/2020 14:36, Chris Plummer wrote:
Hi Alex,
I assume that the following:
65 operator T* () const {
66 return m_ptr;
67 }
Is
Hi Chris,
On 01/22/2020 19:21, Chris Plummer wrote:
On 1/22/20 12:23 PM, Alex Menkov wrote:
Hi Chris,
On 01/17/2020 14:36, Chris Plummer wrote:
Hi Alex,
I assume that the following:
65 operator T* () const {
66 return m_ptr;
67 }
Is used here:
183 AutoArrayPtr err
On 1/22/20 12:23 PM, Alex Menkov wrote:
Hi Chris,
On 01/17/2020 14:36, Chris Plummer wrote:
Hi Alex,
I assume that the following:
65 operator T* () const {
66 return m_ptr;
67 }
Is used here:
183 AutoArrayPtr errmsg(new char[strlen(str) + 32]); \
184 if (err
Hi Chris,
On 01/17/2020 14:36, Chris Plummer wrote:
Hi Alex,
I assume that the following:
65 operator T* () const {
66 return m_ptr;
67 }
Is used here:
183 AutoArrayPtr errmsg(new char[strlen(str) + 32]); \
184 if (errmsg == nullptr) { \
I just don't underst
Hi Alex,
I assume that the following:
65 operator T* () const {
66 return m_ptr;
67 }
Is used here:
183 AutoArrayPtr errmsg(new char[strlen(str) + 32]); \
184 if (errmsg == nullptr) { \
I just don't understand how this works. Somehow it seems the "T*"
operator app
Need 2nd reviewer.
--alex
On 01/14/2020 13:10, serguei.spit...@oracle.com wrote:
Hi Alex,
Thank you for the update!
It looks good.
Still incorrect indent:
103 ~AutoJavaString() { 104 if (m_buf) { 105
m_env->ReleaseStringUTFChars(m_str, m_buf); 106 } 107 } 108 109 operator
const char* () co
Hi Alex,
Thank you for the update!
It looks good.
Still incorrect indent:
103 ~AutoJavaString() { 104 if (m_buf) { 105
m_env->ReleaseStringUTFChars(m_str, m_buf); 106 } 107 } 108 109 operator
const char* () const { 110 return m_buf; 111 } ... 133 void
setReleaseMode(jint mode) {
134 release
Hi Serguei,
Thank you for the review.
updated webrev:
http://cr.openjdk.java.net/~amenkov/jdk15/WinDbg_improve/webrev.02/
On 01/13/2020 16:39, serguei.spit...@oracle.com wrote:
Hi Alex,
It looks pretty good.
Just some minor comments below.
The class AutoCOMPtr has unfixed indents.
I guess, th
Hi Alex,
It looks pretty good.
Just some minor comments below.
The class AutoCOMPtr has unfixed indents.
I guess, the function AutoArrayPtr.asPtr()
is not used anymore and can be deleted.
I'd suggest to remove first level '()'
Ping.
Updated copyright header (to 2020) in place.
--alex
On 12/19/2019 15:34, Alex Menkov wrote:
Hi all,
Please review a fix for
https://bugs.openjdk.java.net/browse/JDK-8235846
webrev:
http://cr.openjdk.java.net/~amenkov/jdk15/WinDbg_improve/webrev.01/
Main goal of the change is to improve
Hi all,
Please review a fix for
https://bugs.openjdk.java.net/browse/JDK-8235846
webrev:
http://cr.openjdk.java.net/~amenkov/jdk15/WinDbg_improve/webrev.01/
Main goal of the change is to improve error reporting (we have several
bugs and need at least COM error codes for WinDbg calls).
Also the
15 matches
Mail list logo
