Re: RFR: JDK-8240340: java/lang/management/ThreadMXBean/Locks.java is buggy

Hi Alex, The update looks good. Thanks, Serguei On 3/9/20 12:15, Alex Menkov wrote: Updated webrev: http://cr.openjdk.java.net/~amenkov/jdk15/ThreadMXBean_Locks_test/webrev.02/ Changes are in LockFreeLogger comments only. --alex On 03/08/2020 21:19, David Holmes wrote: P.S. Forgot to

Re: RFR: JDK-8240340: java/lang/management/ThreadMXBean/Locks.java is buggy

Looks good. Thanks, David On 10/03/2020 5:15 am, Alex Menkov wrote: Updated webrev: http://cr.openjdk.java.net/~amenkov/jdk15/ThreadMXBean_Locks_test/webrev.02/ Changes are in LockFreeLogger comments only. --alex On 03/08/2020 21:19, David Holmes wrote: P.S. Forgot to note however that

Re: RFR: JDK-8240340: java/lang/management/ThreadMXBean/Locks.java is buggy

Updated webrev: http://cr.openjdk.java.net/~amenkov/jdk15/ThreadMXBean_Locks_test/webrev.02/ Changes are in LockFreeLogger comments only. --alex On 03/08/2020 21:19, David Holmes wrote: P.S. Forgot to note however that you need to update the documentation for the logger now as the mention

Re: RFR: JDK-8240340: java/lang/management/ThreadMXBean/Locks.java is buggy

On 03/06/2020 23:28, serguei.spit...@oracle.com wrote: Hi David and Alex, My understanding is that previous implementation collected logs separately for each thread in TLS, and at the end, merged and sorted out the output by log id. So, the result is that all messages are serialized at the

Re: RFR: JDK-8240340: java/lang/management/ThreadMXBean/Locks.java is buggy

P.S. Forgot to note however that you need to update the documentation for the logger now as the mention of "per-thread logs" makes no sense now. Also in the spirit of not using @author, and because this is no longer the code created by Jaroslav, please delete the @author line. Thanks, David

Re: RFR: JDK-8240340: java/lang/management/ThreadMXBean/Locks.java is buggy

Hi Alex, On 6/03/2020 4:54 am, Alex Menkov wrote: Hi David, Thanks you for the review. On 03/04/2020 17:50, David Holmes wrote: Hi Alex, On 5/03/2020 10:30 am, Alex Menkov wrote: Hi all, please review the fix for https://bugs.openjdk.java.net/browse/JDK-8240340 webrev: http://cr.openjdk.ja

Re: RFR: JDK-8240340: java/lang/management/ThreadMXBean/Locks.java is buggy

Hi David and Alex, My understanding is that previous implementation collected logs separately for each thread in TLS, and at the end, merged and sorted out the output by log id. So, the result is that all messages are serialized at the end. Alex changed the implementation but the result is the

Re: RFR: JDK-8240340: java/lang/management/ThreadMXBean/Locks.java is buggy

Hi Alex, It looks good to me. Thanks, Serguei On 3/4/20 16:30, Alex Menkov wrote: Hi all, please review the fix for https://bugs.openjdk.java.net/browse/JDK-8240340 webrev: http://cr.openjdk.java.net/~amenkov/jdk15/ThreadMXBean_Locks_test/webrev/ changes: - assertThreadState method: don't r

Re: RFR: JDK-8240340: java/lang/management/ThreadMXBean/Locks.java is buggy

Hi David, Thanks you for the review. On 03/04/2020 17:50, David Holmes wrote: Hi Alex, On 5/03/2020 10:30 am, Alex Menkov wrote: Hi all, please review the fix for https://bugs.openjdk.java.net/browse/JDK-8240340 webrev: http://cr.openjdk.java.net/~amenkov/jdk15/ThreadMXBean_Locks_test/webrev

Re: RFR: JDK-8240340: java/lang/management/ThreadMXBean/Locks.java is buggy

Hi Alex, On 5/03/2020 10:30 am, Alex Menkov wrote: Hi all, please review the fix for https://bugs.openjdk.java.net/browse/JDK-8240340 webrev: http://cr.openjdk.java.net/~amenkov/jdk15/ThreadMXBean_Locks_test/webrev/ changes: - assertThreadState method: don't re-read thread state throwing exce

RFR: JDK-8240340: java/lang/management/ThreadMXBean/Locks.java is buggy

Hi all, please review the fix for https://bugs.openjdk.java.net/browse/JDK-8240340 webrev: http://cr.openjdk.java.net/~amenkov/jdk15/ThreadMXBean_Locks_test/webrev/ changes: - assertThreadState method: don't re-read thread state throwing exception (as we got weird error like "Thread WaitingThre