Hi Magnus,
Some minor mistakes below, but otherwise looks good. Also copyrights
need updating. I don't need to see another webrev.
thanks,
Chris
---
old/src/jdk.hotspot.agent/share/classes/sun/jvm/hotspot/code/MethodHandlesAdapterBlob.java
2020-04-14 12:47:05.098156117 +0200
+++
new/src/j
Hi Magnus,
This looks okay to me unless there is a better solution.
Thanks,
Serguei
On 4/14/20 04:04, Magnus Ihse Bursie wrote:
As a first step towards fixing deprecation warnings in SA, all the
references (200+) to the deprecated java.util.Observer and Observable
needs to be fixed, otherwise
Hello Magnus,
I'll let someone else judge the validity of the approach, though I think
it seems ok.
src/jdk.hotspot.agent/share/classes/sun/jvm/hotspot/utilities/GenericGrowableArray.java:
Double imports.
src/jdk.hotspot.agent/share/classes/sun/jvm/hotspot/oops/InstanceKlass.java:
Triple i
On 2020-04-14 14:44, coleen.phillim...@oracle.com wrote:
This looks good to me since we can't remove this.
Thanks for your review!
Does jdk.hotspot.agent follow the Hotspot review rules requiring two
Reviewers?
The patch complains that for your Observer.java:
\ No newline at end of file
Y
This looks good to me since we can't remove this. The patch complains
that for your Observer.java:
\ No newline at end of file
Thanks,
Coleen
On 4/14/20 7:04 AM, Magnus Ihse Bursie wrote:
As a first step towards fixing deprecation warnings in SA, all the
references (200+) to the deprecate
As a first step towards fixing deprecation warnings in SA, all the
references (200+) to the deprecated java.util.Observer and Observable
needs to be fixed, otherwise all other changes will drown in this one.
This solution is the result of the preceding discussions in
serviceability-dev. That m
