Hi,
Please review the code changes for
https://bugs.openjdk.java.net/browse/JDK-8150900.
Webrev Link: http://cr.openjdk.java.net/~csahu/8150900/webrev.00/
Enhancement Brief: A new variant of flag "diagnostic_pd" is implemented. All
flags which are diagnostic in nature and platform de
hi Cheleswer,
#1 Shouldn’t the following files be modified as well? :
open:
src/cpu/sparc/vm/globals_sparc.hpp
src/cpu/x86/vm/globals_x86.hpp
src/cpu/zero/vm/globals_zero.hpp
closed:
cpu/arm/vm/globals_arm.hpp
share/vm/runtime/globals_ext.hpp
share/vm/runtime/os_ext.hpp
#2 Bunch of header f
Hi Gerard,
> -Original Message-
> From: Gerard Ziemski
> Sent: Monday, May 02, 2016 9:07 PM
> To: Cheleswer Sahu
> Cc: hotspot-runtime-...@openjdk.java.net; serviceability-
> d...@openjdk.java.net
> Subject: Re: RFR[9u-dev]: 8150900: Implement diagnostic_pd
>
&g
-...@openjdk.java.net; serviceability-
d...@openjdk.java.net
Subject: Re: RFR[9u-dev]: 8150900: Implement diagnostic_pd
hi Cheleswer,
#1 Shouldn’t the following files be modified as well? :
open:
src/cpu/sparc/vm/globals_sparc.hpp
src/cpu/x86/vm/globals_x86.hpp
src/cpu/zero/vm/globals_zero.hpp
closed:
cpu
viceability-dev@openjdk.java.net; hotspot-runtime-
> d...@openjdk.java.net
> Subject: Re: RFR[9u-dev]: 8150900: Implement diagnostic_pd
>
>
> Thanks Cheleswer, looks good to me too, have been over the macros as
> much as I can!
>
> Thanks
> Kevin
>
>
>
> On
Walls
>> Sent: Friday, May 06, 2016 3:53 PM
>> To: Cheleswer Sahu; Gerard Ziemski
>> Cc: serviceability-dev@openjdk.java.net; hotspot-runtime-
>> d...@openjdk.java.net
>> Subject: Re: RFR[9u-dev]: 8150900: Implement diagnostic_pd
>>
>>
>> Thanks Chele
quot;d...@openjdk.java.net
Subject: Re: RFR[9u-dev]: 8150900: Implement diagnostic_pd
Thanks Cheleswer, looks good to me too, have been over the macros as
much as I can!
Thanks
Kevin
On 03/05/2016 07:34, Cheleswer Sahu wrote:
Hi Gerard,
-Original Message-
From: Gerard Ziemski
Walls; Gerard Ziemski; serviceability-dev@openjdk.java.net;
hotspot-runtime-...@openjdk.java.net
Subject: RE: RFR[9u-dev]: 8150900: Implement diagnostic_pd
Thanks Christian for review. I will correct the alignment.
Regards,
Cheleswer
From: Christian Thalinger
Sent: Wednesday, May 11
gt; From: Cheleswer Sahu
> Sent: Wednesday, May 11, 2016 2:29 PM
> To: Christian Thalinger
> Cc: Kevin Walls; Gerard Ziemski; serviceability-dev@openjdk.java.net;
> hotspot-runtime-...@openjdk.java.net
> Subject: RE: RFR[9u-dev]: 8150900: Implement diagnostic_pd
>
>
ntime-...@openjdk.java.net
Subject: Re: RFR[9u-dev]: 8150900: Implement diagnostic_pd
src/share/vm/runtime/globals.hpp
- develop_pd(bool, ImplicitNullChecks, \
+ diagnostic_pd(bool, ImplicitNullChecks,
\
"Gen
ility-dev@openjdk.java.net;
hotspot-runtime-...@openjdk.java.net
Subject: RE: RFR[9u-dev]: 8150900: Implement diagnostic_pd
Thanks Christian for review. I will correct the alignment.
Regards,
Cheleswer
From: Christian Thalinger
Sent: Wednesday, May 11, 2016 1:00 AM
To: Cheleswer Sahu
Cc:
v.01/
Regards,
Cheleswer
From: Cheleswer Sahu
Sent: Wednesday, May 11, 2016 2:29 PM
To: Christian Thalinger
Cc: Kevin Walls; Gerard Ziemski;
serviceability-dev@openjdk.java.net;
hotspot-runtime-...@openjdk.java.net
Subject: RE: RFR[9u-dev]: 8150900: Implement diagnostic_pd
Thanks Christian for
12 matches
Mail list logo