LGTM++
Thanks,
Serguei
On 12/12/18 12:15, Alex Menkov wrote:
Looks good to me.
--alex
On 12/12/2018 11:25, JC Beyler wrote:
Thanks both for the review, I fixed both issues and here is the new
webrev, let me know what you think:
Webrev: http://cr.openjdk.java.net/~jcbeyler/8201655/webrev.0
Looks good to me.
--alex
On 12/12/2018 11:25, JC Beyler wrote:
Thanks both for the review, I fixed both issues and here is the new
webrev, let me know what you think:
Webrev: http://cr.openjdk.java.net/~jcbeyler/8201655/webrev.06/
Bug: https://bugs.openjdk.java.net/browse/JDK-8201655
Thanks!
Hi Alex,
Nice catch!
It is about the following fragment:
726 for (i = 0; i < thread_stats.number_threads; i++) {
727 if (strcmp(expected_name, thread_stats.threads[i])) {
728 return FALSE;
729 } else {
730 found_thread = TRUE;
731 }
732 }
733 return found_thread;
734 }
Also, I'
Hi Jc,
The fix looks good.
The only note is checkThreadSamplesOnlyFrom native function
implementation - the cycle looks confusing.
As far as I got the function should check that thread_stats contains
only 1 thread and name of the thread is the same as name of the
specified thread.
And for err
Hi Jc,
Alex will take a look at the test update.
Thanks,
Serguei
On 11/12/18 9:53 AM, JC Beyler wrote:
Hi Serguei,
Thanks for the update and thanks for testing mach5. Serguei sent me
that the testing passed mach5 testing, could I get another review to
be able to push it?
Thanks!
Jc
On Tu
Hi Jc,
Thank you for the update!
It looks good.
It is great that testing on your side is Okay.
I'll submit a mach5 job soon (today or tomorrow).
Thanks,
Serguei
On 11/6/18 20:03, JC Beyler wrote:
Hi Jc,
Not sure, I understand a motivation for this change:
- if (JvmtiExport::should_post_sampled_object_alloc()) {
+ {
Also, I'm not sure this is still needed:
+#include "prims/jvmtiEventController.inline.hpp"
+#include "prims/jvmtiThreadState.inline.hpp"
I expected you'd just revert all th
Hi Jc,
Okay, I see your point: the change in memAllocator.cpp is for
performance.
Do you have any measurements showing a performance difference?
Also, do you need me to submit a mach5 test run?
Thanks,
Serguei
On 11/5/
Hi Jc,
It looks good in general but I have some comments below.
http://cr.openjdk.java.net/%7Ejcbeyler/8201655/webrev.02/src/hotspot/share/gc/shared/memAllocator.cpp.udiff.html
+static bool thread_enabled_for_one_jvmti_env() {
+ JavaThread *thread
Hi Jc,
I'm looking at it now.
Need to double-check something.
Thanks,
Serguei
On 10/26/18 10:48, JC Beyler wrote:
Hi all,
When working on the heap sampling, I had
Hi all,
When working on the heap sampling, I had promised to do the per thread
event so here it is!
Could I get a review for this:
Webrev: http://cr.openjdk.java.net/~jcbeyler/8201655/webrev.02/
Bug: https://bugs.openjdk.java.net/browse/JDK-8201655
I was thinking of adding GC-dev for the memAllo
11 matches
Mail list logo
