Re: RFR (S) 8074292: nsk/jdb/kill/kill001: generateOopMap.cpp assert(bb->is_reachable()) failed

2020-04-15 Thread coleen . phillimore
On 4/15/20 1:28 AM, David Holmes wrote: On 14/04/2020 10:36 pm, coleen.phillim...@oracle.com wrote: On 4/13/20 10:49 PM, David Holmes wrote: Hi Coleen, On 14/04/2020 12:34 am, coleen.phillim...@oracle.com wrote: Summary: Do not install async exceptions at_safepoint for each bytecode. I'm

Re: RFR (S) 8074292: nsk/jdb/kill/kill001: generateOopMap.cpp assert(bb->is_reachable()) failed

2020-04-14 Thread David Holmes
On 14/04/2020 10:36 pm, coleen.phillim...@oracle.com wrote: On 4/13/20 10:49 PM, David Holmes wrote: Hi Coleen, On 14/04/2020 12:34 am, coleen.phillim...@oracle.com wrote: Summary: Do not install async exceptions at_safepoint for each bytecode. I'm still not certain that we have to go this f

Re: RFR (S) 8074292: nsk/jdb/kill/kill001: generateOopMap.cpp assert(bb->is_reachable()) failed

2020-04-14 Thread coleen . phillimore
On 4/13/20 10:49 PM, David Holmes wrote: Hi Coleen, On 14/04/2020 12:34 am, coleen.phillim...@oracle.com wrote: Summary: Do not install async exceptions at_safepoint for each bytecode. I'm still not certain that we have to go this far to solve this problem, but it does sound like a relati

Re: RFR (S) 8074292: nsk/jdb/kill/kill001: generateOopMap.cpp assert(bb->is_reachable()) failed

2020-04-13 Thread David Holmes
Hi Coleen, On 14/04/2020 12:34 am, coleen.phillim...@oracle.com wrote: Summary: Do not install async exceptions at_safepoint for each bytecode. I'm still not certain that we have to go this far to solve this problem, but it does sound like a relatively simple solution provided there are no u

Re: RFR (S) 8074292: nsk/jdb/kill/kill001: generateOopMap.cpp assert(bb->is_reachable()) failed

2020-04-13 Thread coleen . phillimore
et Subject: RFR (S) 8074292: nsk/jdb/kill/kill001: generateOopMap.cpp assert(bb->is_reachable()) failed Summary: Do not install async exceptions at_safepoint for each bytecode. See CR for a lot more details.  This change calls a new InterpreterRuntime::at_safepoint_async_safe() which installs t

RE: RFR (S) 8074292: nsk/jdb/kill/kill001: generateOopMap.cpp assert(bb->is_reachable()) failed

2020-04-13 Thread Doerr, Martin
--Original Message- > From: hotspot-dev On Behalf Of > coleen.phillim...@oracle.com > Sent: Montag, 13. April 2020 16:34 > To: hotspot-dev developers ; > serviceability-dev@openjdk.java.net > Subject: RFR (S) 8074292: nsk/jdb/kill/kill001: generateOopMap.cpp > assert(bb->is_reacha

RFR (S) 8074292: nsk/jdb/kill/kill001: generateOopMap.cpp assert(bb->is_reachable()) failed

2020-04-13 Thread coleen . phillimore
Summary: Do not install async exceptions at_safepoint for each bytecode. See CR for a lot more details.  This change calls a new InterpreterRuntime::at_safepoint_async_safe() which installs the async exception in the interpreter at backward branches and returns.  This uses safepoint polling co