Hi Jc,
79 size_t len;
80 char * result;
81 const char * const format = "%s .%s :" JLONG_FORMAT;
82 char dummy = 0;
83
84 pMN = getMethodName(pJvmtiEnv, method);
85 if ( ! pMN )
86 return strdup("NONE");
87
88 len = snprintf(&dummy, sizeof(du
Hi Jc,
It looks pretty good to me.
One minor comment:
http://cr.openjdk.java.net/%7Ejcbeyler/8201224/webrev.03/test/hotspot/jtreg/vmTestbase/vm/mlvm/indy/func/jvmti/share/IndyRedefineClass.c.udiff.html
locStr = locationToString(jvmti_env, metho
Hi Jc,
Looks good to me. I'm okay with using "buffer=NULL, len=0" approach.
The only note - could you fix indent of the inserted lines for
consistency (they have 2 spaces indents, but the files use 4 spaces
indents). No need to resend webrev.
--alex
On 08/14/2018 21:26, JC Beyler wrote:
Hi
Hi Alex,
Thanks for looking at it. That simplifies the webrev to this then:
http://cr.openjdk.java.net/~jcbeyler/8201224/webrev.02/
I inlined a few comments on your answers.
Thanks for the review and hopefully the new one is better :-)
Thanks,
Jc
On Tue, Aug 14, 2018 at 3:16 PM Alex Menkov
w
Hi Jc,
Calculation of the required buffer size ("old fashion way") looks
error-prone.
I don't think we need to care about ancient SUSv2, I suppose C99 is
supported by all (or almost all) compilers.
But if you want to keep the code SUSv2-compatible, you can do something like
char dummy = 0;
Hi all,
Anybody motivated to look at this change? :)
Webrev: http://cr.openjdk.java.net/~jcbeyler/8201224/webrev.01/
Bug: https://bugs.openjdk.java.net/browse/JDK-8201224
Let me know what you think!
Jc
On Wed, Aug 8, 2018 at 11:34 AM JC Beyler wrote:
> Hi all,
>
> Here is a revised webrev th
> Ps: A lot of these tests seem to be in GCC style (where spaces are all
> over the place, 4 space indent, etc.), should we do a one-pass per
> folder to make it into more standard hotspot style?
If you do whitespace/style cleanups, please do them with a separate bug.
Dan
On 8/3/18 12:11 AM,
