Re: RFR (XS): 8232182: RedefineNestmateAttr/TestNestmateAttr.java failes due to ObjectCollectedException

2019-10-15 Thread David Holmes
Hi Martin, On 16/10/2019 2:38 am, Martin Buchholz wrote: A slightly cleaner way to do this is probably via try { ... } finally { reachabilityFence(topLevelHostA); } instead of a static field The reachability is not confined to that method. The class needs to be kept alive so that the method

Re: RFR (XS): 8232182: RedefineNestmateAttr/TestNestmateAttr.java failes due to ObjectCollectedException

2019-10-15 Thread Martin Buchholz
A slightly cleaner way to do this is probably via try { ... } finally { reachabilityFence(topLevelHostA); } instead of a static field On Mon, Oct 14, 2019 at 12:15 AM David Holmes wrote: > Bug: https://bugs.openjdk.java.net/browse/JDK-8232182 > webrev: http://cr.openjdk.java.net/~dholmes/82321

Re: RFR (XS): 8232182: RedefineNestmateAttr/TestNestmateAttr.java failes due to ObjectCollectedException

2019-10-14 Thread David Holmes
Thanks for the reviews Paul and Serguei! David On 15/10/2019 4:43 am, serguei.spit...@oracle.com wrote: Hi David, +1 Thanks, Serguei On 10/14/19 07:46, Hohensee, Paul wrote: Looks good. Paul On 10/14/19, 12:16 AM, "serviceability-dev on behalf of David Holmes" david.hol...@oracle.com>

Re: RFR (XS): 8232182: RedefineNestmateAttr/TestNestmateAttr.java failes due to ObjectCollectedException

2019-10-14 Thread serguei.spit...@oracle.com
Hi David, +1 Thanks, Serguei On 10/14/19 07:46, Hohensee, Paul wrote: Looks good. Paul On 10/14/19, 12:16 AM, "serviceability-dev on behalf of David Holmes" wrote: Bug: https://bugs.openjdk.java.net/browse/JDK-8232182 webrev: http://cr.openjdk.java.net/~dholmes/8232182/webrev/

Re: RFR (XS): 8232182: RedefineNestmateAttr/TestNestmateAttr.java failes due to ObjectCollectedException

2019-10-14 Thread Hohensee, Paul
Looks good. Paul On 10/14/19, 12:16 AM, "serviceability-dev on behalf of David Holmes" wrote: Bug: https://bugs.openjdk.java.net/browse/JDK-8232182 webrev: http://cr.openjdk.java.net/~dholmes/8232182/webrev/ Running this test with ZGC showed that a class we were still interes

RFR (XS): 8232182: RedefineNestmateAttr/TestNestmateAttr.java failes due to ObjectCollectedException

2019-10-14 Thread David Holmes
Bug: https://bugs.openjdk.java.net/browse/JDK-8232182 webrev: http://cr.openjdk.java.net/~dholmes/8232182/webrev/ Running this test with ZGC showed that a class we were still interested in could become unloaded. Simple fix is to store the Class reference in a static field. Thanks, David