Re: RFR (XS) 8215329: Modify ZGC requirement for HeapMonitorThreadTest.java

2018-12-15 Thread Per Liden
Just a follow up. After some further debugging, the real cause for this issue turned out to be a bug in JNI IsSameObject(). Fix currently out for review on hotspot-runtime-dev. https://bugs.openjdk.java.net/browse/JDK-8215451 cheers, Per On 12/14/2018 07:52 PM, JC Beyler wrote: Thanks all, t

Re: RFR (XS) 8215329: Modify ZGC requirement for HeapMonitorThreadTest.java

2018-12-13 Thread serguei.spit...@oracle.com
+1 Thanks, Serguei On 12/13/18 09:40, Alex Menkov wrote: +1 --alex On 12/13/2018 08:59, JC Beyler wrote: Hi Per, Thanks for the messages and review :-). I believe that actually what happened was that when JDK11 was close to release both ZGC and HeapMonitoring tried to get in. In a last e

Re: RFR (XS) 8215329: Modify ZGC requirement for HeapMonitorThreadTest.java

2018-12-13 Thread Alex Menkov
+1 --alex On 12/13/2018 08:59, JC Beyler wrote: Hi Per, Thanks for the messages and review :-). I believe that actually what happened was that when JDK11 was close to release both ZGC and HeapMonitoring tried to get in. In a last effort, we turned off this test for ZGC as it was showing tes

Re: RFR (XS) 8215329: Modify ZGC requirement for HeapMonitorThreadTest.java

2018-12-13 Thread JC Beyler
Hi Per, Thanks for the messages and review :-). I believe that actually what happened was that when JDK11 was close to release both ZGC and HeapMonitoring tried to get in. In a last effort, we turned off this test for ZGC as it was showing test failures for ZGC. It's a bit fuzzy to be honest (I wa

Re: RFR (XS) 8215329: Modify ZGC requirement for HeapMonitorThreadTest.java

2018-12-13 Thread Per Liden
Hi, me again ;) I think I've found the root cause of this. There's a tiny race in the ZGC allocation path, which can lead to pre-mature OOME being thrown. It's not trivial to fix, so I suggest you go ahead with your original patch (Looks good btw), and I'll file a separate bug to fix the ZGC

Re: RFR (XS) 8215329: Modify ZGC requirement for HeapMonitorThreadTest.java

2018-12-13 Thread Per Liden
Hi again, I ran this test some more and managed to get an OOME even with a 768M heap. I'm getting a bit suspicious that something else is wrong here. Let me dig into this some more and see if I can understand what the real issue is. cheers, Per On 12/13/2018 10:31 AM, Per Liden wrote: Hi J

Re: RFR (XS) 8215329: Modify ZGC requirement for HeapMonitorThreadTest.java

2018-12-13 Thread Per Liden
Hi JC, What's the reason to exclude ZGC from this test to begin with? From what I can tell, it's because the test is using a slightly too small heap, or are there some other reason? I ran it a few times using various heap sizes and the test passes with ZGC when using anything above 612M. So if

RFR (XS) 8215329: Modify ZGC requirement for HeapMonitorThreadTest.java

2018-12-12 Thread JC Beyler
Hi all, When working on another webrev, I saw this problem: Webrev: http://cr.openjdk.java.net/~jcbeyler/8215329/webrev.00/ Bug: https://bugs.openjdk.java.net/browse/JDK-8215329 (Basically, from what I understood from an email from Per Liden: - @requires !vm.gc.Z -> ZGC is built in the JDK