Re: RFR (XS) 8215495: Always set isCopy

2018-12-19 Thread yumin qi
Looks good to me. Thanks Yumin On Wed, Dec 19, 2018 at 7:42 AM JC Beyler wrote: > Hi all, > > Could I get a second review for this please? :) > > Webrev: http://cr.openjdk.java.net/~jcbeyler/8215495/webrev.01/ > Bug: https://bugs.openjdk.java.net/browse/JDK-8215495 > > Thanks! > Jc > > On Mon,

Re: RFR (XS) 8215495: Always set isCopy

2018-12-17 Thread David Holmes
LGTM. Thanks, David On 18/12/2018 8:53 am, JC Beyler wrote: Sounds good to me: For the odd corner case: Webrev: http://cr.openjdk.java.net/~jcbeyler/8215495/webrev.01/ Bug: https://bugs.openjdk.java.net/browse/JDK-8215495 Thanks! Jc

Re: RFR (XS) 8215495: Always set isCopy

2018-12-17 Thread JC Beyler
Sounds good to me: For the odd corner case: Webrev: http://cr.openjdk.java.net/~jcbeyler/8215495/webrev.01/ Bug: https://bugs.openjdk.java.net/browse/JDK-8215495 Thanks! Jc On Mon, Dec 17, 2018 at 2:39 PM David Holmes wrote: > Hi Jc, > > On 18/12/2018 8:12 am, JC Beyler wrote: > > Hi David,

Re: RFR (XS) 8215495: Always set isCopy

2018-12-17 Thread David Holmes
Hi Jc, On 18/12/2018 8:12 am, JC Beyler wrote: Hi David, I understand the rationale behind the "If the method does return NULL, then isCopy's value is undefined". But what about the DEFINE_GETSCALARARRAYELEMENTS case? It does this:   if (len == 0) { \     /* Empty array: legal but

Re: RFR (XS) 8215495: Always set isCopy

2018-12-17 Thread JC Beyler
Hi David, I understand the rationale behind the "If the method does return NULL, then isCopy's value is undefined". But what about the DEFINE_GETSCALARARRAYELEMENTS case? It does this: if (len == 0) { \ /* Empty array: legal but useless, can't return NULL. \ * Return a pointer to

Re: RFR (XS) 8215495: Always set isCopy

2018-12-17 Thread David Holmes
Hi Jc, On 18/12/2018 3:42 am, JC Beyler wrote: Hi all, Could I get a review for this webrev: Webrev: http://cr.openjdk.java.net/~jcbeyler/8215495/webrev.00/ Bug: https://bugs.openjdk.java.net/browse/JDK-8215495 isCopy only has to be set if the method executes successfully "If isCopy is not

Re: RFR (XS) 8215495: Always set isCopy

2018-12-17 Thread Daniel D. Daugherty
Adding hotspot-runtime-dev@... since this is JNI. Dan On 12/17/18 12:42 PM, JC Beyler wrote: Hi all, Could I get a review for this webrev: Webrev: http://cr.openjdk.java.net/~jcbeyler/8215495/webrev.00/ Bug: https://bugs.openjdk.java.net/browse/JDK-8215495 Thanks, Jc