> http://cr.openjdk.java.net/~rkennke/shenandoah-upstream/05/
C2 changes look good to me.
Roland.
On 12/4/18 8:10 AM, Roman Kennke wrote:
> Webrevs:
> http://cr.openjdk.java.net/~rkennke/shenandoah-upstream/05/
>
> [ ] shenandoah-gc
> [ ] shenandoah-tests
These two parts look good.
-Aleksey
signature.asc
Description: OpenPGP digital signature
Hi Coleen,
> http://cr.openjdk.java.net/~rkennke/shenandoah-upstream/05/shenandoah-gc/src/hotspot/share/gc/shenandoah/vm_operations_shenandoah.cpp.html
>
>
> Can you rename these to shenandoahVMOperations.hpp/cpp to match the
> newly agreed upon naming convention for this?
>
> See 8214791: Cons
http://cr.openjdk.java.net/~rkennke/shenandoah-upstream/05/shenandoah-gc/src/hotspot/share/gc/shenandoah/vm_operations_shenandoah.cpp.html
Can you rename these to shenandoahVMOperations.hpp/cpp to match the
newly agreed upon naming convention for this?
See 8214791: Consistently name gc files
Thanks, Leonid, for reviewing!
Roman
> Hi
>
> The shared tests changes looks good for me. Thank you for fixing and testing
> different combinations.
>
> Leonid
>
>> On Dec 3, 2018, at 11:10 PM, Roman Kennke wrote:
>>
>> Round 5 of Shenandoah review includes:
>> - A fix for the @requires ta
Hi
The shared tests changes looks good for me. Thank you for fixing and testing
different combinations.
Leonid
> On Dec 3, 2018, at 11:10 PM, Roman Kennke wrote:
>
> Round 5 of Shenandoah review includes:
> - A fix for the @requires tag in TestFullGCCountTest.java. It should be
> correct now
Round 5 of Shenandoah review includes:
- A fix for the @requires tag in TestFullGCCountTest.java. It should be
correct now. We believe the CMS @requires was also not quite right and
fixed it the same.
It reads now: Don't run this test if:
- Actual GC set by harness is CMS *and* ExplicitGCInvokesC
