Hello,
Please review the fix for JDK-8167337
Bug Id : https://bugs.openjdk.java.net/browse/JDK-8167337
Webrev : http://cr.openjdk.java.net/~asapre/webrev/2017/JDK-8167337/webrev.00/
Thanks,
Amit
Amit,
Changes looks good to me.
-Dmitry
On 2017-01-13 09:17, Amit Sapre wrote:
> Hello,
>
>
>
> Please review the fix for JDK-8167337
>
>
>
> Bug Id : https://bugs.openjdk.java.net/browse/JDK-8167337
>
> Webrev :
> http://cr.openjdk.java.net/~asapre/webrev/2017/JDK-8167337/webrev.00/
>
Thanks Dmitry for the review.
Can I have one more reviewer for this fix ?
Thanks,
Amit
> -Original Message-
> From: Dmitry Samersoff
> Sent: Sunday, January 15, 2017 4:49 PM
> To: Amit Sapre; serviceability-dev
> Subject: Re: RFR : JDK-8167337 - When jmxremote.port=0,
day, January 15, 2017 4:49 PM
To: Amit Sapre; serviceability-dev
Subject: Re: RFR : JDK-8167337 - When jmxremote.port=0, JDP broadcasts
"0" instead of assigned port
Amit,
Changes looks good to me.
-Dmitry
On 2017-01-13 09:17, Amit Sapre wrote:
Hello,
Please review the fix for JD
the review.
>
> Can I have one more reviewer for this fix ?
>
> Thanks,
> Amit
>
> > -Original Message-
> > From: Dmitry Samersoff
> > Sent: Sunday, January 15, 2017 4:49 PM
> > To: Amit Sapre; serviceability-dev
> > Subject: Re: RFR : JDK-
nal Message-----
From: Dmitry Samersoff
Sent: Sunday, January 15, 2017 4:49 PM
To: Amit Sapre; serviceability-dev
Subject: Re: RFR : JDK-8167337 - When jmxremote.port=0, JDP broadcasts
"0" instead of assigned port
Amit,
Changes looks good to me.
-Dmitry
On 2017-01-13 09:17, Am
l.contains(":0/")) {...}
$.02, Roger
Regards
Harsha
On Monday 16 January 2017 11:16 AM, Amit Sapre wrote:
Thanks Dmitry for the review.
Can I have one more reviewer for this fix ?
Thanks,
Amit
-----Original Message-
From: Dmitry Samersoff
Sent: Sunday, January 15, 2017 4:
")) {...}
$.02, Roger
Regards
Harsha
On Monday 16 January 2017 11:16 AM, Amit Sapre wrote:
Thanks Dmitry for the review.
Can I have one more reviewer for this fix ?
Thanks,
Amit
-Original Message-
From: Dmitry Samersoff
Sent: Sunday, January 15, 2017 4:49 PM
To: Amit
Roger Riggs
> Sent: Tuesday, January 17, 2017 10:05 PM
> To: serviceability-dev@openjdk.java.net
> Subject: Re: RFR : JDK-8167337 - When jmxremote.port=0, JDP broadcasts
> "0" instead of assigned port
>
> Hi,
>
> yes, but the pattern looks for the ":" before
Roger Riggs; serviceability-dev@openjdk.java.net; Harsha Wardhana B
> Subject: RE: RFR : JDK-8167337 - When jmxremote.port=0, JDP broadcasts
> "0" instead of assigned port
>
> Hello,
>
> Looks like basic check on Jdp packet includes a check for
> JMX_SERVICE_URL
&g
-
From: Amit Sapre
Sent: Wednesday, January 18, 2017 2:09 PM
To: Roger Riggs; serviceability-dev@openjdk.java.net; Harsha Wardhana B
Subject: RE: RFR : JDK-8167337 - When jmxremote.port=0, JDP broadcasts
"0" instead of assigned port
Hello,
Looks like basic check on Jdp packet includ
Thanks for the review Roger !
From: Roger Riggs
Sent: Friday, January 20, 2017 1:49 AM
To: Amit Sapre; serviceability-dev@openjdk.java.net
Cc: Harsha Wardhana B; Dmitry Samersoff
Subject: Re: RFR : JDK-8167337 - When jmxremote.port=0, JDP broadcasts "0"
instead of assigned port
12 matches
Mail list logo
