8026948: JvmtiEnv::SetBreakpoint and JvmtiEnv::ClearBreakpoint might not
work with anonymous classes
Summary: Walk methods in breakpoints for marking on stack so they aren't
deallocated by redefine classes. Use class_holder rather than
class_loader to keep GC from reclaiming class owning the me
Coleen,
It looks good, thank you for fixing it!
Thanks,
Serguei
On 10/30/13 7:54 PM, Coleen Phillimore wrote:
8026948: JvmtiEnv::SetBreakpoint and JvmtiEnv::ClearBreakpoint might
not work with anonymous classes
Summary: Walk methods in breakpoints for marking on stack so they
aren't deallocat
On 10/31/2013 12:43 PM, serguei.spit...@oracle.com wrote:
Coleen,
It looks good, thank you for fixing it!
Thanks for the code review Serguei.
Coleen
Thanks,
Serguei
On 10/30/13 7:54 PM, Coleen Phillimore wrote:
8026948: JvmtiEnv::SetBreakpoint and JvmtiEnv::ClearBreakpoint might
not work
Hi Coleen,
this looks great, just one minor nit: could you please update the
comment starting at jvmtiImpl.cpp:242 (which explains why using
allow_unhandled_oop is correct) to use _class_holder instead of
_class_loader?
Thanks,
Erik
On 2013-10-30, Coleen Phillimore wrote:
> 8026948: JvmtiEnv::Se
Looks good!
Thanks,
/Staffan
On 31 okt 2013, at 03:54, Coleen Phillimore
wrote:
> 8026948: JvmtiEnv::SetBreakpoint and JvmtiEnv::ClearBreakpoint might not work
> with anonymous classes
> Summary: Walk methods in breakpoints for marking on stack so they aren't
> deallocated by redefine classe
On 11/1/2013 9:16 AM, Erik Helin wrote:
Hi Coleen,
this looks great, just one minor nit: could you please update the
comment starting at jvmtiImpl.cpp:242 (which explains why using
allow_unhandled_oop is correct) to use _class_holder instead of
_class_loader?
I fixed it and the : in JvmtiBreak
