The tests looks good! Thank you very much for fixing.
// Katja
On 03/23/2015 12:41 PM, Staffan Larsen wrote:
Looks good!
Thanks,
/Staffan
On 23 mar 2015, at 11:55, Jaroslav Bachorik jaroslav.bacho...@oracle.com
wrote:
On 23.3.2015 08:50, Staffan Larsen wrote:
diagnosticCommand.cpp:
-
On 23.3.2015 08:50, Staffan Larsen wrote:
diagnosticCommand.cpp:
- Should SetVMFlagDCmd really be inside #if INCLUDE_SERVICES” ?
Probably not. On the other hand, the JVMTIDataDumpDCmd registration
should probably be guarded by #if INCLUDE_JVMTI
- L227-234: strange indentation
Fixed.
diagnosticCommand.cpp:
- Should SetVMFlagDCmd really be inside #if INCLUDE_SERVICES” ?
- L227-234: strange indentation
/Staffan
On 19 mar 2015, at 10:59, Jaroslav Bachorik jaroslav.bacho...@oracle.com
wrote:
Please, review the following change
Issue :
Looks good!
Erik
Jaroslav Bachorik skrev 2015-03-19 10:59:
Please, review the following change
Issue : https://bugs.openjdk.java.net/browse/JDK-8054890
Webrev: http://cr.openjdk.java.net/~jbachorik/8054890/webrev.00
This patch is about adding 2 new diagnostic commands - VM.set_flag and
Please, review the following change
Issue : https://bugs.openjdk.java.net/browse/JDK-8054890
Webrev: http://cr.openjdk.java.net/~jbachorik/8054890/webrev.00
This patch is about adding 2 new diagnostic commands - VM.set_flag and
JVMTI.data_dump.
VM.set_flag allows to set any writeable flag.
Jaroslav,
src/share/vm/services/diagnosticCommand.cpp
No comments
src/share/vm/services/diagnosticCommand.hpp
Why adding #include services/attachListener.hpp ?
test/serviceability/dcmd/jvmti/DataDumpDcmdTest.java
test/serviceability/dcmd/vm/SetVMFlagTest.java
I don't know the new test
