Re: RFR 8081219: hs_err improvement: Add event logging for class redefinition to the hs_err file

2015-06-03 Thread Coleen Phillimore
Thank you, Serguei! Coleen On 6/3/15 2:16 PM, serguei.spit...@oracle.com wrote: Coleen, The fix is nice, thank you for the update. The whole feature is going to be very useful for us! Thanks, Serguei On 6/3/15 7:03 AM, Coleen Phillimore wrote: Thank you Serguei for the comment. I

Re: RFR 8081219: hs_err improvement: Add event logging for class redefinition to the hs_err file

2015-06-03 Thread Lois Foltan
Looks good! Lois On 6/2/2015 3:58 PM, Coleen Phillimore wrote: Summary: Use the Events::log function to save redefined classes for output to the hs_err file. This change adds lines to the hs_err_pid file which names classes redefined: Classes redefined (2 events): Event: 11.867 Thread

Re: RFR 8081219: hs_err improvement: Add event logging for class redefinition to the hs_err file

2015-06-03 Thread Coleen Phillimore
Thank you Serguei for the comment. I thought of putting the event log first but really wanted it to tell which classes were already redefined. So I decided to improve the error message for printing the VM_Operation to include the class being redefined. With the following change, there's a

Re: RFR 8081219: hs_err improvement: Add event logging for class redefinition to the hs_err file

2015-06-03 Thread serguei.spit...@oracle.com
Coleen, The fix is nice, thank you for the update. The whole feature is going to be very useful for us! Thanks, Serguei On 6/3/15 7:03 AM, Coleen Phillimore wrote: Thank you Serguei for the comment. I thought of putting the event log first but really wanted it to tell which classes were

RFR 8081219: hs_err improvement: Add event logging for class redefinition to the hs_err file

2015-06-02 Thread Coleen Phillimore
Summary: Use the Events::log function to save redefined classes for output to the hs_err file. This change adds lines to the hs_err_pid file which names classes redefined: Classes redefined (2 events): Event: 11.867 Thread 0x7fd378199800 redefined class name=RedefineRunningMethods$B,

Re: RFR 8081219: hs_err improvement: Add event logging for class redefinition to the hs_err file

2015-06-02 Thread serguei.spit...@oracle.com
Coleen, The fix looks good. But I have a question. Would it be useful to log the beginning of a redefinition as well so that it is known what class is currently being redefined? Thanks, Serguei On 6/2/15 12:58 PM, Coleen Phillimore wrote: Summary: Use the Events::log function to save