RFR 8146015: JMXInterfaceBindingTest is failing intermittently for IPv6 addresses

2015-12-23 Thread Jaroslav Bachorik
Please, review the following test change Issue : https://bugs.openjdk.java.net/browse/JDK-8146015 Webrev: http://cr.openjdk.java.net/~jbachorik/8146015/webrev.00 The test fails for IPv6 addresses since the RMI expects an IPv6 address to be properly wrapped in '[]'. In addition to that the logic

[ping] Re: RFR 8146015: JMXInterfaceBindingTest is failing intermittently for IPv6 addresses

2016-01-04 Thread Jaroslav Bachorik
Gentle reminder ... On 23.12.2015 11:26, Jaroslav Bachorik wrote: Please, review the following test change Issue : https://bugs.openjdk.java.net/browse/JDK-8146015 Webrev: http://cr.openjdk.java.net/~jbachorik/8146015/webrev.00 The test fails for IPv6 addresses since the RMI expects an IPv6 ad

[pong] Re: [ping] Re: RFR 8146015: JMXInterfaceBindingTest is failing intermittently for IPv6 addresses

2016-01-05 Thread Jaroslav Bachorik
On 4.1.2016 10:05, Jaroslav Bachorik wrote: Gentle reminder ... On 23.12.2015 11:26, Jaroslav Bachorik wrote: Please, review the following test change Issue : https://bugs.openjdk.java.net/browse/JDK-8146015 Webrev: http://cr.openjdk.java.net/~jbachorik/8146015/webrev.00 The test fails for IP

[ding] Re: jmx-dev [pong] Re: [ping] Re: RFR 8146015: JMXInterfaceBindingTest is failing intermittently for IPv6 addresses

2016-01-07 Thread Jaroslav Bachorik
On 5.1.2016 15:30, Jaroslav Bachorik wrote: On 4.1.2016 10:05, Jaroslav Bachorik wrote: Gentle reminder ... On 23.12.2015 11:26, Jaroslav Bachorik wrote: Please, review the following test change Issue : https://bugs.openjdk.java.net/browse/JDK-8146015 Webrev: http://cr.openjdk.java.net/~jbach

Re: [ding] Re: jmx-dev [pong] Re: [ping] Re: RFR 8146015: JMXInterfaceBindingTest is failing intermittently for IPv6 addresses

2016-01-12 Thread serguei.spit...@oracle.com
On 1/7/16 08:40, Daniel Fuchs wrote: Hi, This looks OK to me. I'm not sure I understand the full impact of the changes in getAddressesForLocalHost() though - so hopefully someone else will jump in to review that part... Hi Jaroslav, I do not understand the full impact of the getAddressesForLo

Re: [ding] Re: jmx-dev [pong] Re: [ping] Re: RFR 8146015: JMXInterfaceBindingTest is failing intermittently for IPv6 addresses

2016-01-12 Thread Jaroslav Bachorik
On 12.1.2016 11:47, serguei.spit...@oracle.com wrote: On 1/7/16 08:40, Daniel Fuchs wrote: Hi, This looks OK to me. I'm not sure I understand the full impact of the changes in getAddressesForLocalHost() though - so hopefully someone else will jump in to review that part... Hi Jaroslav, I do

Re: [ding] Re: jmx-dev [pong] Re: [ping] Re: RFR 8146015: JMXInterfaceBindingTest is failing intermittently for IPv6 addresses

2016-01-12 Thread serguei.spit...@oracle.com
On 1/12/16 03:49, Jaroslav Bachorik wrote: On 12.1.2016 11:47, serguei.spit...@oracle.com wrote: On 1/7/16 08:40, Daniel Fuchs wrote: Hi, This looks OK to me. I'm not sure I understand the full impact of the changes in getAddressesForLocalHost() though - so hopefully someone else will jump in

Re: [ding] Re: jmx-dev [pong] Re: [ping] Re: RFR 8146015: JMXInterfaceBindingTest is failing intermittently for IPv6 addresses

2016-01-13 Thread Jaroslav Bachorik
On 12.1.2016 12:55, serguei.spit...@oracle.com wrote: On 1/12/16 03:49, Jaroslav Bachorik wrote: On 12.1.2016 11:47, serguei.spit...@oracle.com wrote: On 1/7/16 08:40, Daniel Fuchs wrote: Hi, This looks OK to me. I'm not sure I understand the full impact of the changes in getAddressesForLocal

Re: [ding] Re: jmx-dev [pong] Re: [ping] Re: RFR 8146015: JMXInterfaceBindingTest is failing intermittently for IPv6 addresses

2016-01-13 Thread Daniel Fuchs
On 13/01/16 12:16, Jaroslav Bachorik wrote: Thanks. I've added the explanation and also disambiguated the method name a bit. http://cr.openjdk.java.net/~jbachorik/8146015/webrev.01 It looks like no one else is going to jump in and verify the getAddressesForLocalHost() change (basically, excludi

Re: [ding] Re: jmx-dev [pong] Re: [ping] Re: RFR 8146015: JMXInterfaceBindingTest is failing intermittently for IPv6 addresses

2016-01-13 Thread Jaroslav Bachorik
On 13.1.2016 13:00, Daniel Fuchs wrote: On 13/01/16 12:16, Jaroslav Bachorik wrote: Thanks. I've added the explanation and also disambiguated the method name a bit. http://cr.openjdk.java.net/~jbachorik/8146015/webrev.01 It looks like no one else is going to jump in and verify the getAddresses

Re: [ding] Re: jmx-dev [pong] Re: [ping] Re: RFR 8146015: JMXInterfaceBindingTest is failing intermittently for IPv6 addresses

2016-01-13 Thread serguei.spit...@oracle.com
On 1/13/16 03:16, Jaroslav Bachorik wrote: On 12.1.2016 12:55, serguei.spit...@oracle.com wrote: On 1/12/16 03:49, Jaroslav Bachorik wrote: On 12.1.2016 11:47, serguei.spit...@oracle.com wrote: On 1/7/16 08:40, Daniel Fuchs wrote: Hi, This looks OK to me. I'm not sure I understand the full i

Re: jmx-dev [ding] Re: [pong] Re: [ping] Re: RFR 8146015: JMXInterfaceBindingTest is failing intermittently for IPv6 addresses

2016-01-14 Thread Severin Gehwolf
Hi, On Wed, 2016-01-13 at 10:51 -0800, serguei.spit...@oracle.com wrote: > On 1/13/16 03:16, Jaroslav Bachorik wrote: > > On 12.1.2016 12:55, serguei.spit...@oracle.com wrote: > > > On 1/12/16 03:49, Jaroslav Bachorik wrote: > > > > On 12.1.2016 11:47, serguei.spit...@oracle.com wrote: > > > > > O

Re: jmx-dev [ding] Re: [pong] Re: [ping] Re: RFR 8146015: JMXInterfaceBindingTest is failing intermittently for IPv6 addresses

2016-01-15 Thread Jaroslav Bachorik
On 14.1.2016 17:23, Severin Gehwolf wrote: Hi, On Wed, 2016-01-13 at 10:51 -0800, serguei.spit...@oracle.com wrote: > On 1/13/16 03:16, Jaroslav Bachorik wrote: >> On 12.1.2016 12:55, serguei.spit...@oracle.com wrote: >>> On 1/12/16 03:49, Jaroslav Bachorik wrote: On 12.1.2016 11:47, sergue

Re: jmx-dev [ding] Re: [pong] Re: [ping] Re: RFR 8146015: JMXInterfaceBindingTest is failing intermittently for IPv6 addresses

2016-01-15 Thread Severin Gehwolf
Hi, On Fri, 2016-01-15 at 09:50 +0100, Jaroslav Bachorik wrote: > > Sorry for being late in the game with this. > > > > +private static List getAddressesForLocalHost() { > > + > >   try { > > -addrs = InetAddress.getAllByName("localhost"); > > -} catch (UnknownHost

Re: jmx-dev [ding] Re: [pong] Re: [ping] Re: RFR 8146015: JMXInterfaceBindingTest is failing intermittently for IPv6 addresses

2016-01-15 Thread Jaroslav Bachorik
On 15.1.2016 10:24, Severin Gehwolf wrote: Hi, On Fri, 2016-01-15 at 09:50 +0100, Jaroslav Bachorik wrote: Sorry for being late in the game with this. +private static List getAddressesForLocalHost() { + try { -addrs = InetAddress.getAllByName("localhost"); -}

Re: jmx-dev [ding] Re: [pong] Re: [ping] Re: RFR 8146015: JMXInterfaceBindingTest is failing intermittently for IPv6 addresses

2016-01-15 Thread Severin Gehwolf
On Fri, 2016-01-15 at 10:28 +0100, Jaroslav Bachorik wrote: > On 15.1.2016 10:24, Severin Gehwolf wrote: > > Hi, > > > > On Fri, 2016-01-15 at 09:50 +0100, Jaroslav Bachorik wrote: > > > > Sorry for being late in the game with this. > > > > > > > > +private static List getAddressesForLocalHos