Re: RFR 8160892: VM warning: WaitForMultipleObjects timed out

2016-07-14 Thread David Holmes
On 15/07/2016 8:57 AM, Ivan Gerasimov wrote: Hey! I've updated the webrev in place at http://cr.openjdk.java.net/~igerasim/8160892/01/webrev/ Thanks Ivan - looks good. See also: https://bugs.openjdk.java.net/browse/JDK-8160596 https://bugs.openjdk.java.net/browse/JDK-8079441 regarding stran

Re: RFR 8160892: VM warning: WaitForMultipleObjects timed out

2016-07-14 Thread Daniel D. Daugherty
On 7/14/16 4:57 PM, Ivan Gerasimov wrote: Hey! I've updated the webrev in place at http://cr.openjdk.java.net/~igerasim/8160892/01/webrev/ Thumbs up! Dan On 15.07.2016 0:31, Daniel D. Daugherty wrote: On 7/14/16 12:46 PM, Ivan Gerasimov wrote: Thank you David for looking into this! Her

Re: RFR 8160892: VM warning: WaitForMultipleObjects timed out

2016-07-14 Thread Ivan Gerasimov
Hey! I've updated the webrev in place at http://cr.openjdk.java.net/~igerasim/8160892/01/webrev/ On 15.07.2016 0:31, Daniel D. Daugherty wrote: On 7/14/16 12:46 PM, Ivan Gerasimov wrote: Thank you David for looking into this! Here's the webrev updated in accordance with your and Daniel's sug

Re: RFR 8160892: VM warning: WaitForMultipleObjects timed out

2016-07-14 Thread Daniel D. Daugherty
On 7/14/16 12:46 PM, Ivan Gerasimov wrote: Thank you David for looking into this! Here's the webrev updated in accordance with your and Daniel's suggestions: http://cr.openjdk.java.net/~igerasim/8160892/01/webrev/ src/os/windows/vm/os_windows.cpp L3900: bool registered = false;

Re: RFR 8160892: VM warning: WaitForMultipleObjects timed out

2016-07-14 Thread Ivan Gerasimov
Thank you David for looking into this! Here's the webrev updated in accordance with your and Daniel's suggestions: http://cr.openjdk.java.net/~igerasim/8160892/01/webrev/ Please see my answers inline Nit: can we change 'registered_itself" to just "registered" please. Done. Can you explain

Re: RFR 8160892: VM warning: WaitForMultipleObjects timed out

2016-07-11 Thread David Holmes
Hi Ivan, On 7/07/2016 2:55 AM, Ivan Gerasimov wrote: Hello! When fixing JDK-8069048 a potential race was overlooked: 1) Thread A wants to call _endthreadex() and registers itself, 2) Thread B wants to call exit(), takes its turn and raises the flag `process_exiting`, 3) Thread A continues, and

Re: RFR 8160892: VM warning: WaitForMultipleObjects timed out

2016-07-06 Thread Ivan Gerasimov
Thanks Daniel! I'll rearrange comments as you suggest. With kind regards, Ivan On 07.07.2016 0:21, Daniel D. Daugherty wrote: On 7/6/16 10:57 AM, Ivan Gerasimov wrote: Hello! When fixing JDK-8069048 a potential race was overlooked: 1) Thread A wants to call _endthreadex() and registers itse

Re: RFR 8160892: VM warning: WaitForMultipleObjects timed out

2016-07-06 Thread Daniel D. Daugherty
On 7/6/16 10:57 AM, Ivan Gerasimov wrote: Hello! When fixing JDK-8069048 a potential race was overlooked: 1) Thread A wants to call _endthreadex() and registers itself, 2) Thread B wants to call exit(), takes its turn and raises the flag `process_exiting`, 3) Thread A continues, and gets captur

RFR 8160892: VM warning: WaitForMultipleObjects timed out

2016-07-06 Thread Ivan Gerasimov
Hello! When fixing JDK-8069048 a potential race was overlooked: 1) Thread A wants to call _endthreadex() and registers itself, 2) Thread B wants to call exit(), takes its turn and raises the flag `process_exiting`, 3) Thread A continues, and gets captured in the loop at 4020, in SuspendThread(G

RFR 8160892: VM warning: WaitForMultipleObjects timed out

2016-07-06 Thread Ivan Gerasimov
Hello! When fixing JDK-8069048 a potential race was overlooked: 1) Thread A wants to call _endthreadex() and registers itself, 2) Thread B wants to call exit(), takes its turn and raises the flag `process_exiting`, 3) Thread A continues, and gets captured in the loop at 4020, in SuspendThread(G