Re: RFR JDK-8031554: com/sun/tools/attach/BasicTests.java fails intermittently

2014-07-02 Thread Staffan Larsen
instead of null value they will receive InterryptedException). >> >> -JB- >> >>> >>> Shanliang >>>> >>>> -JB- >>>> >>>>> >>>>> Shanliang >>>>> >>>>> Christian T

Re: RFR JDK-8031554: com/sun/tools/attach/BasicTests.java fails intermittently

2014-07-02 Thread shanliang
ion in getOutput(). Thanks, Christian *From:*Staffan Larsen [mailto:staffan.lar...@oracle.com] *Sent:* Friday, June 27, 2014 4:49 AM *To:* shanliang *Cc:* Jaroslav Bachorik; serviceability-dev@openjdk.java.net serviceability-dev@openjdk.java.net; Christian Tornqvist *Subject:* Re: RFR JDK-803

Re: RFR JDK-8031554: com/sun/tools/attach/BasicTests.java fails intermittently

2014-07-02 Thread Jaroslav Bachorik
tedException in getOutput(). Thanks, Christian *From:*Staffan Larsen [mailto:staffan.lar...@oracle.com] *Sent:* Friday, June 27, 2014 4:49 AM *To:* shanliang *Cc:* Jaroslav Bachorik; serviceability-dev@openjdk.java.net serviceability-dev@openjdk.java.net; Christian Tornqvist *Subject:* Re: RFR J

Re: RFR JDK-8031554: com/sun/tools/attach/BasicTests.java fails intermittently

2014-07-01 Thread shanliang
Jaroslav Bachorik; serviceability-dev@openjdk.java.net serviceability-dev@openjdk.java.net; Christian Tornqvist *Subject:* Re: RFR JDK-8031554: com/sun/tools/attach/BasicTests.java fails intermittently It does look suspicious to catch and ignore the InterruptedException, especially since the OutputAnaly

Re: RFR JDK-8031554: com/sun/tools/attach/BasicTests.java fails intermittently

2014-07-01 Thread Jaroslav Bachorik
49 AM *To:* shanliang *Cc:* Jaroslav Bachorik; serviceability-dev@openjdk.java.net serviceability-dev@openjdk.java.net; Christian Tornqvist *Subject:* Re: RFR JDK-8031554: com/sun/tools/attach/BasicTests.java fails intermittently It does look suspicious to catch and ignore the InterruptedExcept

Re: RFR JDK-8031554: com/sun/tools/attach/BasicTests.java fails intermittently

2014-07-01 Thread shanliang
g *Cc:* Jaroslav Bachorik; serviceability-dev@openjdk.java.net serviceability-dev@openjdk.java.net; Christian Tornqvist *Subject:* Re: RFR JDK-8031554: com/sun/tools/attach/BasicTests.java fails intermittently It does look suspicious to catch and ignore the InterruptedException, especially sinc

RE: RFR JDK-8031554: com/sun/tools/attach/BasicTests.java fails intermittently

2014-06-27 Thread Christian Tornqvist
horik; serviceability-dev@openjdk.java.net serviceability-dev@openjdk.java.net; Christian Tornqvist Subject: Re: RFR JDK-8031554: com/sun/tools/attach/BasicTests.java fails intermittently It does look suspicious to catch and ignore the InterruptedException, especially since the OutputAna

Re: RFR JDK-8031554: com/sun/tools/attach/BasicTests.java fails intermittently

2014-06-27 Thread Staffan Larsen
It does look suspicious to catch and ignore the InterruptedException, especially since the OutputAnalyzer constructor will fail in this case. Christian is the original author of these classes: do you know if there is a good rationale for doing this? Or should we propagate the InterruptedExcepti

Re: RFR JDK-8031554: com/sun/tools/attach/BasicTests.java fails intermittently

2014-06-26 Thread shanliang
Jaroslav Bachorik wrote: Hi Shanliang, On 06/26/2014 03:15 PM, shanliang wrote: Hi, Today ProcessTools.executeProcess has the code: new OutputAnalyzer(pb.start()); and OutputAnalyzer constructor calls immediately: exitValue = process.exitValue(); the test got exception because the

Re: RFR JDK-8031554: com/sun/tools/attach/BasicTests.java fails intermittently

2014-06-26 Thread Jaroslav Bachorik
Hi Shanliang, On 06/26/2014 03:15 PM, shanliang wrote: Hi, Today ProcessTools.executeProcess has the code: new OutputAnalyzer(pb.start()); and OutputAnalyzer constructor calls immediately: exitValue = process.exitValue(); the test got exception because the process did not end. Are

RFR JDK-8031554: com/sun/tools/attach/BasicTests.java fails intermittently

2014-06-26 Thread shanliang
Hi, Today ProcessTools.executeProcess has the code: new OutputAnalyzer(pb.start()); and OutputAnalyzer constructor calls immediately: exitValue = process.exitValue(); the test got exception because the process did not end. So a direct solution for the test is not to call: Proces