Hi Alex,
On 22/08/2018 5:36 AM, Alex Menkov wrote:
Hi David,
Updated fix:
http://cr.openjdk.java.net/~amenkov/sh2java/step1_zgc/webrev.01
I used "catch (Throwable)" instead suggested "catch (Error |
RuntimeException ex)" (we want to catch anything can be thrown)
Interesting that it worked.
Hi Alex,
Thank you for the update!
It looks good to me.
Thanks,
Serguei
On 8/21/18 12:36, Alex Menkov wrote:
Hi David,
Updated fix:
http://cr.openjdk.java.net/~amenkov/sh2java/step1_zgc/webrev.01
I used "catch (Throwable)" instead suggested "catch (Error |
RuntimeException ex)" (we want to
Hi David,
Updated fix:
http://cr.openjdk.java.net/~amenkov/sh2java/step1_zgc/webrev.01
I used "catch (Throwable)" instead suggested "catch (Error |
RuntimeException ex)" (we want to catch anything can be thrown)
Also I updated String.split to use \\R for the line-separators as you
suggested
Hi Alex,
The fix looks good modulo comments from David.
Thanks,
Serguei
On 8/20/18 15:24, Alex Menkov wrote:
Hi all,
please review a fix for
https://bugs.openjdk.java.net/browse/JDK-8209605
webrev:
http://cr.openjdk.java.net/~amenkov/sh2java/step1_zgc/webrev/
The fix:
- updates the fix so i
Hi Alex,
On 21/08/2018 8:24 AM, Alex Menkov wrote:
Hi all,
please review a fix for
https://bugs.openjdk.java.net/browse/JDK-8209605
webrev:
http://cr.openjdk.java.net/~amenkov/sh2java/step1_zgc/webrev/
The fix:
- updates the fix so it works as original shell test:
- drops "-Xmx32m" argument
Hi all,
please review a fix for
https://bugs.openjdk.java.net/browse/JDK-8209605
webrev:
http://cr.openjdk.java.net/~amenkov/sh2java/step1_zgc/webrev/
The fix:
- updates the fix so it works as original shell test:
- drops "-Xmx32m" argument for debuggee (for shell test default jtreg
-Xmx512m
