Seems okay.
One nit: existed_map -> existing_map
David
On 16/09/2013 6:58 PM, Dmitry Samersoff wrote:
Staffan,
Thank you! Fixed (in-place).
http://cr.openjdk.java.net/~dsamersoff/JDK-7133122/webrev.01/
-Dmitry
On 2013-09-16 10:04, Staffan Larsen wrote:
A couple of small nits:
line 721: t
Need a second reviewer!
On 2013-09-15 16:59, Dmitry Samersoff wrote:
> Hi Everybody,
>
> http://cr.openjdk.java.net/~dsamersoff/JDK-7133122/webrev.01/
>
> Please review the small fix. This patch was contributed by Yasumasa Suenaga.
>
> -Dmitry
>
--
Dmitry Samersoff
Oracle Java development t
Good!
/Staffan
On 16 sep 2013, at 10:58, Dmitry Samersoff wrote:
> Staffan,
>
> Thank you! Fixed (in-place).
>
> http://cr.openjdk.java.net/~dsamersoff/JDK-7133122/webrev.01/
>
> -Dmitry
>
> On 2013-09-16 10:04, Staffan Larsen wrote:
>> A couple of small nits:
>>
>> line 721: there is a su
Staffan,
Thank you! Fixed (in-place).
http://cr.openjdk.java.net/~dsamersoff/JDK-7133122/webrev.01/
-Dmitry
On 2013-09-16 10:04, Staffan Larsen wrote:
> A couple of small nits:
>
> line 721: there is a superfluous + sign at the beginning of the line.
>
> line 729: confliction -> conflict
>
>
A couple of small nits:
line 721: there is a superfluous + sign at the beginning of the line.
line 729: confliction -> conflict
line 734: to -> with
line 735: overwrite to -> overwrote with
Otherwise looks good.
/Staffan
On 15 sep 2013, at 15:59, Dmitry Samersoff wrote:
> Hi Everybody,
>
Hi Everybody,
http://cr.openjdk.java.net/~dsamersoff/JDK-7133122/webrev.01/
Please review the small fix. This patch was contributed by Yasumasa Suenaga.
-Dmitry
--
Dmitry Samersoff
Oracle Java development team, Saint Petersburg, Russia
* I would love to change the world, but they won't give me
