Serguei,
I run all runtime tests on MAC OS X - lots of tests fails[1], but this
numners is exactly the same with or without my fix.
I'd considered it as a good result and plan to push changes tomorrow.
Do you have any concerns?
[1]
TOTAL TESTS IN RUN: 1043
TEST PASS: 502; 48% rate
TEST FAIL:
Dmitry,
Thank you for running the tests, it is good to be safe.
In general it is Ok to judge on the fix quality basing on the test
result differences.
But I'm surprised the TEST FAIL rate is so high (is it normal for Mac OS?).
You may want to take a look how many of them are unexpected.
It is
Serguei,
UTE attempts to run windows specific (dotnet) tests[1] and it cause huge
failure rate.
I'd contacted SQE (Leonid) and he is in process of investigation
whether it is result of wrong MAC setup or bug in latest UTE.
I'd checked - none of these failures is related to my fix.
[1]
Ok.
Thanks, Dmitry!
Serguei
On 10/2/13 3:40 PM, Dmitry Samersoff wrote:
Serguei,
UTE attempts to run windows specific (dotnet) tests[1] and it cause huge
failure rate.
I'd contacted SQE (Leonid) and he is in process of investigation
whether it is result of wrong MAC setup or bug in latest
Looks good.
The only thing that is missing is the guarantee() that was present in the OS X
code before:
guarantee(thread_id != 0, just checking);
Could you add it back?
Thanks,
/Staffan
On 24 sep 2013, at 00:57, Dmitry Samersoff dmitry.samers...@oracle.com wrote:
Please review changes:
Dmitry,
Looks good. Minor comments:
os_bsd.cpp:
+ #elif __APPLE__ //XNU kernel
+ // despite the fact mach port is actually not a thread id use it
+ // instead of syscall(SYS_thread_selfid) as it certenly fit to u4
Is it a typo for 'certainly' here?
certenly = certainly
fit = fits
Sergey,
I'm rely on JPRT in testing. Also I run some tests on FreeBSD.
So if you think I should run extra tests, let me know which one, I'll
run it.
Actually the fix doesn't change MacOS X implementation - just move a
call to ::pthread_mach_thread_np to different place so I don't expect
any
Staffan and Yumin,
Thank you for feedback.
Fixed (in place, please press shift-reload)
http://cr.openjdk.java.net/~dsamersoff/JDK-8022616/webrev.02/
-Dmitry
On 2013-09-24 11:57, Dmitry Samersoff wrote:
Please review changes:
http://cr.openjdk.java.net/~dsamersoff/JDK-8022616/webrev.02/
On 9/24/13 12:01 PM, Dmitry Samersoff wrote:
Sergey,
I'm rely on JPRT in testing. Also I run some tests on FreeBSD.
It should not be too hard to run the same subset of tests on Mac OS, right?
So if you think I should run extra tests, let me know which one, I'll
run it.
Actually the
Serguei,
Agree! Try to test it better tomorrow. Have to find MacOS X machine to
install UTE first.
-Dmitry
On 2013-09-24 23:34, serguei.spit...@oracle.com wrote:
On 9/24/13 12:01 PM, Dmitry Samersoff wrote:
Sergey,
I'm rely on JPRT in testing. Also I run some tests on FreeBSD.
It should
Dmitry,
Thank you for taking this action.
I did not know, the extra machine setup is needed though. :(
Thanks,
Serguei
On 9/24/13 12:38 PM, Dmitry Samersoff wrote:
Serguei,
Agree! Try to test it better tomorrow. Have to find MacOS X machine to
install UTE first.
-Dmitry
On 2013-09-24
Looks good!
Thanks,
/Staffan
On 24 sep 2013, at 12:20, Dmitry Samersoff dmitry.samers...@oracle.com wrote:
Staffan and Yumin,
Thank you for feedback.
Fixed (in place, please press shift-reload)
http://cr.openjdk.java.net/~dsamersoff/JDK-8022616/webrev.02/
-Dmitry
On 2013-09-24
Looks good.
Thanks,
Serguei
On 9/24/13 12:20 PM, Dmitry Samersoff wrote:
Staffan and Yumin,
Thank you for feedback.
Fixed (in place, please press shift-reload)
http://cr.openjdk.java.net/~dsamersoff/JDK-8022616/webrev.02/
-Dmitry
On 2013-09-24 11:57, Dmitry Samersoff wrote:
Please review
13 matches
Mail list logo
