Looks good to me too except the indentation as Staffan pointed out (line
458-459)
Mandy
On 5/27/2013 7:47 AM, Daniel D. Daugherty wrote:
Sure! Chime!!!
> http://cr.openjdk.java.net/~nloodin/6470730/webrev.00/
src/share/classes/sun/tools/jconsole/VMPanel.java
No comments (presuming you fix
Sure! Chime!!!
> http://cr.openjdk.java.net/~nloodin/6470730/webrev.00/
src/share/classes/sun/tools/jconsole/VMPanel.java
No comments (presuming you fix the indentation on lines 458-459)
Thumbs up!
FYI: Mandy Chung is the person to ping if/when you have a more
complicated jconsole fix...
Could you please chime in? :)
/Nisse
On 05/24/2013 06:33 PM, Staffan Larsen wrote:
Looks good, but the indentation is wrong in one place.
/Staffan
On 24 maj 2013, at 16:13, Nils Loodin wrote:
Simple fix not to add a confusing dialog.
Bug: https://jbs.oracle.com/bugs/browse/JDK-6470730
We
Looks good, but the indentation is wrong in one place.
/Staffan
On 24 maj 2013, at 16:13, Nils Loodin wrote:
> Simple fix not to add a confusing dialog.
>
> Bug: https://jbs.oracle.com/bugs/browse/JDK-6470730
>
> Webrev:
> http://cr.openjdk.java.net/~nloodin/6470730/webrev.00/
>
> Regards,
>
Looks good! (not a reviewer)
Nils Loodin skrev 2013-05-24 16:13:
Simple fix not to add a confusing dialog.
Bug: https://jbs.oracle.com/bugs/browse/JDK-6470730
Webrev:
http://cr.openjdk.java.net/~nloodin/6470730/webrev.00/
Regards,
Nils Loodin
On 2013-05-24 16:13, Nils Loodin wrote:
Simple fix not to add a confusing dialog.
Bug: https://jbs.oracle.com/bugs/browse/JDK-6470730
Webrev:
http://cr.openjdk.java.net/~nloodin/6470730/webrev.00/
Fix looks simple and good to me. However, I don't have my OpenJDK
username yet, so this might n
Wrong link:
On 05/24/2013 04:13 PM, Nils Loodin wrote:
Simple fix not to add a confusing dialog.
Bug: https://jbs.oracle.com/bugs/browse/JDK-6470730
This should be http://bugs.sun.com/view_bug.do?bug_id=6470730
Webrev:
http://cr.openjdk.java.net/~nloodin/6470730/webrev.00/
Regards,
Nils Lo
